Add primitive type and string type to the number info....

Add primitive type and string type to the number info.

This change adds two new type attributes to  the lattice
defined in the class NumberInfo. Currently the new types
are not used yet.

I plan to rename NumberInfo into TypeInfo as a separate change.


Committed: http://code.google.com/p/v8/source/detail?r=4250

[Erik Corry, 2010-03-24 12:18:10]

LGTM

http://codereview.chromium.org/1249002/diff/1/3
File src/number-info.h (right):

http://codereview.chromium.org/1249002/diff/1/3#newcode51
src/number-info.h:51: // We know is's a primitive type.
is's -> it is

http://codereview.chromium.org/1249002/diff/1/3#newcode71
src/number-info.h:71: int answer = type_ & 15;
Please use hex for things that are bit-oriented.

http://codereview.chromium.org/1249002/diff/1/3#newcode83
src/number-info.h:83: t = (t != kUnknownType) ? static_cast<Type>(t | 16) : t;
Can we use kPrimitiveType here instead of 16.  Also I think it's clearer to have
(x == y) ? ... : ...
instead of (x != y) ? ... : ...

http://codereview.chromium.org/1249002/diff/1/3#newcode161
src/number-info.h:161: kPrimitiveType = 16,
Hex.

[fschneider, 2010-03-24 12:32:43]

http://codereview.chromium.org/1249002/diff/1/3
File src/number-info.h (right):

http://codereview.chromium.org/1249002/diff/1/3#newcode51
src/number-info.h:51: // We know is's a primitive type.
On 2010/03/24 12:18:15, Erik Corry wrote:
> is's -> it is

Done.

http://codereview.chromium.org/1249002/diff/1/3#newcode71
src/number-info.h:71: int answer = type_ & 15;
On 2010/03/24 12:18:15, Erik Corry wrote:
> Please use hex for things that are bit-oriented.

Done.

http://codereview.chromium.org/1249002/diff/1/3#newcode83
src/number-info.h:83: t = (t != kUnknownType) ? static_cast<Type>(t | 16) : t;
On 2010/03/24 12:18:15, Erik Corry wrote:
> Can we use kPrimitiveType here instead of 16.  Also I think it's clearer to
have
> (x == y) ? ... : ...
> instead of (x != y) ? ... : ...

Done.

http://codereview.chromium.org/1249002/diff/1/3#newcode161
src/number-info.h:161: kPrimitiveType = 16,
On 2010/03/24 12:18:15, Erik Corry wrote:
> Hex.

Done. (for all enum values)