Issue 12489: Remove file_util::kPathSeparator from posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12489: Remove file_util::kPathSeparator from posix. (Closed)

Created:
12 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove file_util::kPathSeparator from posix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6099

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -205 lines)			Patch
M	base/file_path.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/file_path.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	base/file_util.h	View		5 chunks	+25 lines, -9 lines	0 comments	Download
M	base/file_util.cc	View	1	8 chunks	+79 lines, -135 lines	0 comments	Download
M	base/file_util_linux.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	base/file_util_mac.mm	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/file_util_unittest.cc	View	1	5 chunks	+58 lines, -0 lines	0 comments	Download
M	base/file_util_win.cc	View		2 chunks	+56 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_unittest.cc	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	net/url_request/url_request_unittest.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	net/url_request/url_request_unittest.cc	View		1 chunk	+3 lines, -7 lines	0 comments	Download
M	webkit/glue/dom_serializer_unittest.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View		2 chunks	+8 lines, -11 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View		3 chunks	+12 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

This is the first step to completely removing this deprecated constant. There are a *lot* ...

12 years ago (2008-11-26 21:35:07 UTC) #1

tony

12 years ago (2008-11-26 22:04:43 UTC) #2

LGTM, thanks for doing this.

On 2008/11/26 21:35:07, Evan Stade wrote:
> This is the first step to completely removing this deprecated constant. There
> are a *lot* of places in win code that still use it, so that will be the work
of
> another patch. I removed some file_util functions from the posix build that we
> will eventually want, but don't currently use. Reimplementing those not to use
> kPathSeparator is also on my TODO list.

Expand Messages | Collapse Messages