Issue 12473: * Complete case independent support in Irregexp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12473: * Complete case independent support in Irregexp. (Closed)

Created:
12 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

* Complete case independent support in Irregexp. Committed: http://code.google.com/p/v8/source/detail?r=853

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -6 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/jsregexp.h	View	2 chunks	+8 lines, -0 lines	1 comment	Download
M	src/jsregexp.cc	View	5 chunks	+21 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years ago (2008-11-27 06:49:39 UTC) #2

Lgtm

http://codereview.chromium.org/12473/diff/1/4
File src/jsregexp.cc (right):

http://codereview.chromium.org/12473/diff/1/4#newcode476
Line 476: //PrintF("\n\nSubject string: '%s'\n\n",
*(two_byte_subject->ToCString()));
Either comment it back in or remove it.

http://codereview.chromium.org/12473/diff/1/3
File src/jsregexp.h (right):

http://codereview.chromium.org/12473/diff/1/3#newcode745
Line 745: explicit Analysis(bool case_independent)
We're somewhat inconsistent in what we call this: case_independent, ignore_case,
etc.  We should settle on just one and I vote for ignore_case.

Expand Messages | Collapse Messages