Added a debugger call to run a JavaScript function in the debugger. When call...

Added a debugger call to run a JavaScript function in the debugger. When called the debugger will be entered and the JavaScript function will be called with the debugger ExecutionState object as its first parameter.

This makes it possible to get information like current line number, current script resource, backtrace information etc. which is not part of the normal API.

Committed: http://code.google.com/p/v8/source/detail?r=854

[Mads Ager (chromium), 2008-11-26 15:02:42]

LGTM.

Maybe you can add a test that shows what happens if you pass in a closure that
uses local variables from its context:

var x = 3;
function (execstate) {
  execstate.something == x;
}

This should just work, but a test would be nice.

http://codereview.chromium.org/12472/diff/1/4
File src/api.cc (right):

http://codereview.chromium.org/12472/diff/1/4#newcode2907
Line 2907: if (!i::V8::HasBeenSetup()) v8::Undefined();
You probably mean to return here.

http://codereview.chromium.org/12472/diff/1/6
File src/debug.cc (right):

http://codereview.chromium.org/12472/diff/1/6#newcode1670
Line 1670: Object** argv[kArgc] = { exec_state.location(),
Doesn't this fit on one line?

http://codereview.chromium.org/12472/diff/1/2
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/12472/diff/1/2#newcode3210
Line 3210: // JavaScript in the debugger.
JavaScript function.

http://codereview.chromium.org/12472/diff/1/2#newcode3276
Line 3276: v8::Script::Compile(v8::String::New("function f()
{CheckFrameCount(2)}; f()"))->Run();
Is this line too long?

[Søren Thygesen Gjesse, 2008-11-26 19:53:11]

Added a function which captures a context variable as an additional test.

http://codereview.chromium.org/12472/diff/1/4
File src/api.cc (right):

http://codereview.chromium.org/12472/diff/1/4#newcode2907
Line 2907: if (!i::V8::HasBeenSetup()) v8::Undefined();
On 2008/11/26 15:02:42, Mads Ager wrote:
> You probably mean to return here.

Changd to return an empty handle as returning v8::Undefined() if V8 is not
initialized makes no sense. Also added an ON_BAILOUT check.

http://codereview.chromium.org/12472/diff/1/6
File src/debug.cc (right):

http://codereview.chromium.org/12472/diff/1/6#newcode1670
Line 1670: Object** argv[kArgc] = { exec_state.location(),
On 2008/11/26 15:02:42, Mads Ager wrote:
> Doesn't this fit on one line?

Changed.

http://codereview.chromium.org/12472/diff/1/2
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/12472/diff/1/2#newcode3210
Line 3210: // JavaScript in the debugger.
On 2008/11/26 15:02:42, Mads Ager wrote:
> JavaScript function.

Changed.

http://codereview.chromium.org/12472/diff/1/2#newcode3276
Line 3276: v8::Script::Compile(v8::String::New("function f()
{CheckFrameCount(2)}; f()"))->Run();
On 2008/11/26 15:02:42, Mads Ager wrote:
> Is this line too long?

It is no more.

[Christian Plesner Hansen, 2008-11-27 07:09:08]

Lgtm

http://codereview.chromium.org/12472/diff/9/210
File include/v8-debug.h (right):

http://codereview.chromium.org/12472/diff/9/210#newcode132
Line 132: // Run a JavaScript function in the debugger.
From this comment it's not obvious what this means, exactly.  Is it just a way
to get your hands on the execution state?  What would people use this for?

[Søren Thygesen Gjesse, 2008-11-27 08:01:36]

http://codereview.chromium.org/12472/diff/9/210
File include/v8-debug.h (right):

http://codereview.chromium.org/12472/diff/9/210#newcode132
Line 132: // Run a JavaScript function in the debugger.
On 2008/11/27 07:09:08, Christian Plesner Hansen wrote:
> From this comment it's not obvious what this means, exactly.  Is it just a way
> to get your hands on the execution state?  What would people use this for?

Added some documentation including a simple sample for getting the current line
of JavaScript executing.