Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/site_instance.h

Issue 12451: Don't create separate SiteInstances for pages from the same domain and scheme... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/site_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/site_instance.h
===================================================================
--- chrome/browser/site_instance.h (revision 6002)
+++ chrome/browser/site_instance.h (working copy)
@@ -15,7 +15,7 @@
//
// A SiteInstance is a data structure that is associated with all pages in a
// given instance of a web site. Here, a web site is identified by its
-// registered domain name, scheme, and port. An instance includes all pages
+// registered domain name and scheme. An instance includes all pages
// that are connected (i.e., either a user or a script navigated from one
// to the other). We represent instances using the BrowsingInstance class.
//
@@ -70,8 +70,9 @@
RenderProcessHost* GetProcess();
// Set / Get the web site that this SiteInstance is rendering pages for.
- // This includes the scheme, registered domain, and port. If the URL does
- // not have a valid registered domain, then the full hostname is stored.
+ // This includes the scheme and registered domain, but not the port. If the
+ // URL does not have a valid registered domain, then the full hostname is
+ // stored.
void SetSite(const GURL& url);
const GURL& site() const { return site_; }
bool has_site() const { return has_site_; }
@@ -100,15 +101,14 @@
// Darin suggests.
static SiteInstance* CreateSiteInstance(Profile* profile);
- // Returns the site for the given URL, which includes only the scheme,
- // registered domain, and port. Returns an empty GURL if the URL has no
- // host.
+ // Returns the site for the given URL, which includes only the scheme and
+ // registered domain. Returns an empty GURL if the URL has no host.
static GURL GetSiteForURL(const GURL& url);
// Return whether both URLs are part of the same web site, for the purpose of
// assigning them to processes accordingly. The decision is currently based
// on the registered domain of the URLs (google.com, bbc.co.uk), as well as
- // the scheme (https, http) and port. This ensures that two pages will be in
+ // the scheme (https, http). This ensures that two pages will be in
// the same process if they can communicate with other via JavaScript.
// (e.g., docs.google.com and mail.google.com have DOM access to each other
// if they both set their document.domain properties to google.com.)
« no previous file with comments | « no previous file | chrome/browser/site_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698