Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 12443: Don't create separate SiteInstances for pages from different ports (Closed)

Created:
12 years ago by Charlie Reis
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't create separate SiteInstances for pages from the same domain and scheme but from different ports. (These pages can still access each other.) BUG=4792 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6014 (See http://codereview.chromium.org/12451)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M chrome/browser/site_instance.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/site_instance.cc View 3 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/site_instance_unittest.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Charlie Reis
12 years ago (2008-11-25 19:53:14 UTC) #1
abarth-chromium
LGTM.
12 years ago (2008-11-25 20:00:16 UTC) #2
darin (slow to review)
12 years ago (2008-11-25 20:28:45 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698