Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 12428: Fixed Visual Studio build with snapshot when V8 is checked out in a directory... (Closed)

Created:
12 years ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fixed Visual Studio build with snapshot when V8 is checked out in a directory with spaces in the path. Committed: http://code.google.com/p/v8/source/detail?r=831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/visual_studio/v8_snapshot.vcproj View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
12 years ago (2008-11-25 10:58:30 UTC) #1
Lasse Reichstein
12 years ago (2008-11-25 12:35:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698