Implement more sanity tests for Memcheck/Valgrind

tools/valgrind/memcheck_analyze.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # memcheck_analyze.py
 
 ''' Given a valgrind XML file, parses errors and uniques them.'''
 
 import gdb_helper
@@ skipping 293 matching lines @@
       return False
     if '</valgrindoutput>' in line:
       # valgrind often has garbage after </valgrindoutput> upon crash
       f.truncate()
       return True
 
 class MemcheckAnalyze:
   ''' Given a set of Valgrind XML files, parse all the errors out of them,
   unique them and output the results.'''
 
-  SANITY_TEST_SUPPRESSION = "Memcheck sanity test"
+  SANITY_TEST_SUPPRESSIONS = [
+      "Memcheck sanity test (array deleted without []).",
+      "Memcheck sanity test (malloc/read left).",
+      "Memcheck sanity test (malloc/read right).",
+      "Memcheck sanity test (malloc/write left).",
+      "Memcheck sanity test (malloc/write right).",
+      "Memcheck sanity test (memory leak).",
+      "Memcheck sanity test (new/read left).",
+      "Memcheck sanity test (new/read right).",
+      "Memcheck sanity test (new/write left).",
+      "Memcheck sanity test (new/write right).",
+      "Memcheck sanity test (single element deleted with []).",
+      "Memcheck sanity test (write after delete).",
+      "Memcheck sanity test (write after free).",
+  ]
+
   def __init__(self, source_dir, files, show_all_leaks=False, use_gdb=False):
     '''Reads in a set of files.
 
     Args:
       source_dir: Path to top of source tree for this build
       files: A list of filenames.
       show_all_leaks: whether to show even less important leaks
     '''
 
     # Beyond the detailed errors parsed by ValgrindError above,
@@ skipping 107 matching lines @@
 
   def Report(self, check_sanity=False):
     if self._parse_failed:
       logging.error("FAIL! Couldn't parse Valgrind output file")
       return -2
 
     is_sane = False
     print "-----------------------------------------------------"
     print "Suppressions used:"
     print "  count name"
+    remaining_sanity_supp = set(MemcheckAnalyze.SANITY_TEST_SUPPRESSIONS)
     for item in sorted(self._suppcounts.items(), key=lambda (k,v): (v,k)):
       print "%7s %s" % (item[1], item[0])
-      if item[0].startswith(MemcheckAnalyze.SANITY_TEST_SUPPRESSION):
-        is_sane = True
+      if item[0] in remaining_sanity_supp:
+        remaining_sanity_supp.remove(item[0])
+    if len(remaining_sanity_supp) == 0:
+      is_sane = True
     print "-----------------------------------------------------"
     sys.stdout.flush()
 
     retcode = 0
     if self._errors:
       logging.error("FAIL! There were %s errors: " % len(self._errors))
 
       global TheAddressTable
       if TheAddressTable != None:
         TheAddressTable.ResolveAll()
 
       for error in self._errors:
         logging.error(error)
 
       retcode = -1
 
     # Report tool's insanity even if there were errors.
     if check_sanity and not is_sane:
       logging.error("FAIL! Sanity check failed!")
+      logging.info("The following test errors were not handled: ")
+      for supp in remaining_sanity_supp:
+        logging.info("  " + supp)
       retcode = -3
 
     if retcode != 0:
       return retcode
 
     logging.info("PASS! No errors found!")
     return 0
 
 def _main():
   '''For testing only. The MemcheckAnalyze class should be imported instead.'''
   retcode = 0
   parser = optparse.OptionParser("usage: %prog [options] <files to analyze>")
   parser.add_option("", "--source_dir",
                     help="path to top of source tree for this build"
                     "(used to normalize source paths in baseline)")
 
   (options, args) = parser.parse_args()
   if not len(args) >= 1:
     parser.error("no filename specified")
   filenames = args
 
   analyzer = MemcheckAnalyze(options.source_dir, filenames, use_gdb=True)
   retcode = analyzer.Report()
 
   sys.exit(retcode)
 
 if __name__ == "__main__":
   _main()