Implement more sanity tests for Memcheck/Valgrind

tools/valgrind/memcheck/suppressions.txt

 # There are three kinds of suppressions in this file.
 # 1. third party stuff we have no control over
 #
 # 2. intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 #
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
@@ skipping 441 matching lines @@
    fun:_PR_ImplicitInitialization
    ...
    fun:_ZN4base14EnsureNSPRInitEv
    fun:ChromeMain
    fun:main
 }
 #-----------------------------------------------------------------------
 # 2. intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 {
-   Memcheck sanity test (ToolsSanityTest.MemoryLeak).
+   Memcheck sanity test (memory leak).
    Memcheck:Leak
    fun:_Zna*
    fun:_ZN31ToolsSanityTest_MemoryLeak_Test8TestBodyEv
 }
 {
+   Memcheck sanity test (malloc/read left).
+   Memcheck:Addr1
+   fun:_Z29ReadValueOutOfArrayBoundsLeftPc
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN43ToolsSanityTest_AccessesToMallocMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (malloc/read right).
+   Memcheck:Addr1
+   fun:_Z30ReadValueOutOfArrayBoundsRightPc*
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN43ToolsSanityTest_AccessesToMallocMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (malloc/write left).
+   Memcheck:Addr1
+   fun:_Z30WriteValueOutOfArrayBoundsLeftPc
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN43ToolsSanityTest_AccessesToMallocMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (malloc/write right).
+   Memcheck:Addr1
+   fun:_Z31WriteValueOutOfArrayBoundsRightPc*
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN43ToolsSanityTest_AccessesToMallocMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (new/read left).
+   Memcheck:Addr1
+   fun:_Z29ReadValueOutOfArrayBoundsLeftPc
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN40ToolsSanityTest_AccessesToNewMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (new/read right).
+   Memcheck:Addr1
+   fun:_Z30ReadValueOutOfArrayBoundsRightPc*
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN40ToolsSanityTest_AccessesToNewMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (new/write left).
+   Memcheck:Addr1
+   fun:_Z30WriteValueOutOfArrayBoundsLeftPc
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN40ToolsSanityTest_AccessesToNewMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (new/write right).
+   Memcheck:Addr1
+   fun:_Z31WriteValueOutOfArrayBoundsRightPc*
+   fun:_Z14MakeSomeErrorsPc*
+   fun:_ZN40ToolsSanityTest_AccessesToNewMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (write after free).
+   Memcheck:Addr1
+   fun:_ZN43ToolsSanityTest_AccessesToMallocMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (write after delete).
+   Memcheck:Addr1
+   fun:_ZN40ToolsSanityTest_AccessesToNewMemory_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (array deleted without []).
+   Memcheck:Free
+   ...
+   fun:_ZN46ToolsSanityTest_ArrayDeletedWithoutBraces_Test8TestBodyEv
+}
+{
+   Memcheck sanity test (single element deleted with []).
+   Memcheck:Free
+   ...
+   fun:_ZN51ToolsSanityTest_SingleElementDeletedWithBraces_Test8TestBodyEv
+}
+{
    logging::InitLogging never frees filename. It would be hard to free properly.
    Memcheck:Leak
    ...
    fun:_ZN7logging11InitLoggingEPKcNS_18LoggingDestinationENS_15LogLockingStateENS_20OldFileDeletionStateE
 }
 {
    # See comment on struct CheckOpString
    logging::MakeCheckOpString result not freed because app is aborting
    Memcheck:Leak
    fun:_Znw*
@@ skipping 2078 matching lines @@
    fun:_ZNK7testing8internal18FunctionMockerBaseIFbvEE20PerformDefaultActionERKNSt3tr15tupleINS4_10_NullClassES6_S6_S6_S6_S6_S6_S6_S6_S6_EERKSs
    fun:_ZN7testing8internal18ActionResultHolderIbE20PerformDefaultActionIFbvENSt3tr15tupleINS5_10_NullClassES7_S7_S7_S7_S7_S7_S7_S7_S7_EEEES2_PKNS0_18FunctionMockerBaseIT_EERKT0_RKSs
    fun:_ZN7testing8internal18FunctionMockerBaseIFbvEE10InvokeWithERKNSt3tr15tupleINS4_10_NullClassES6_S6_S6_S6_S6_S6_S6_S6_S6_EE
    fun:_ZN7testing8internal14FunctionMockerIFbvEE6InvokeEv
    fun:_ZN12browser_sync19SyncBackendHostMock12RequestPauseEv
    ...
    fun:_ZN18ProfileSyncService29StartProcessingChangesIfReadyEv
    fun:_ZN18ProfileSyncService20OnBackendInitializedEv
    fun:_ZN12browser_sync15SyncBackendHost4Core14NotifyFrontendENS1_20FrontendNotificationE
 }