Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 12415: Attempted fix for some wheel/touchpad scrolling errors.... (Closed)

Created:
12 years, 1 month ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
amit, chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Attempted fix for some wheel/touchpad scrolling errors. The nTrackPos member of SCROLLINFO is not actually the scroll position, and can't be set by a SetScrollInfo() call. Thus the SetScrollInfo() calls were actually setting the scroll position of the fake scroll bars to the upper left corner. This change sets the scroll position to the center of each scrollbar, in the hopes that some mouse drivers were querying the scroll position or thumb position and not sending scroll left/up messages when they found the page was already scrolled all the way left/up. This change may not help, but it won't hurt, and the old code was definitely wrong. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/web_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Peter Kasting
12 years, 1 month ago (2008-11-25 00:45:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698