Un-duplicate EvictFileFromSystemCache....

Un-duplicate EvictFileFromSystemCache.

Change required for http://codereview.chromium.org/9639 .

[brettw, 2008-11-24 20:37:56]

I thought about this for a while, it's too bad there's no good place for it.

I think my favorite solution is to instead move test_file_util to base and have
_win, etc versions of the implementation. This way, it's clear what the
separation is between file_util and the test ones.

Currently, this change loses a little of that separation (it would be really bad
if somebody used that function in production code) and also leaves
test_file_util in kind of a stupid state with only one function in it.

What do you think about this approach?

http://codereview.chromium.org/12407/diff/1/4
File base/file_util_mac.mm (right):

http://codereview.chromium.org/12407/diff/1/4#newcode32
Line 32: EvictFileFromSystemCache(const wchar_t* file) {
Put this on the same line as the return type.

[please use my chromium address, 2008-11-24 21:20:03]

On 2008/11/24 20:37:56, brettw wrote:
> I thought about this for a while, it's too bad there's no good place for it.
> 
> I think my favorite solution is to instead move test_file_util to base and
have
> _win, etc versions of the implementation. This way, it's clear what the
> separation is between file_util and the test ones.
> 
> Currently, this change loses a little of that separation (it would be really
bad
> if somebody used that function in production code) and also leaves
> test_file_util in kind of a stupid state with only one function in it.
> 
> What do you think about this approach?

Modified to do exactly that (and _mac.mm nit fixed). This change would also
require adjustment to vcproj and xcode files. I can adjust vcprojs after file
changes look ok, but additional help would be needed for xcdodeprojs.

[brettw, 2008-11-24 21:37:59]

I don't see the new implementation for CopyRecursiveDirNoCache.

Also, (maybe this is a Reitveld issue) I don't see that the old test_file_util
files are deleted (they don't have a D next to them).

Otherwise I think this is good. Maybe it's best if a Mac person checks this in
for you since they can make the changes and then commit.

[please use my chromium address, 2008-11-25 18:35:44]

On 2008/11/24 21:37:59, brettw wrote:
> I don't see the new implementation for CopyRecursiveDirNoCache.

It was hidden because I svn mv-ed the file. Now it is added as a new file to
de-confuse the tools and make the diff appliable by patch.

> Also, (maybe this is a Reitveld issue) I don't see that the old test_file_util
> files are deleted (they don't have a D next to them).

For my gcl they have, but after uploading they switch to M. Looks like a
Rietveld glitch.

> Otherwise I think this is good. Maybe it's best if a Mac person checks this in
> for you since they can make the changes and then commit.

I consulted mac changes with pinkerton, will add him for review.

[please use my chromium address, 2008-11-25 18:36:28]

Please review mac, scons and vcproj changes.

[pink (ping after 24hrs), 2008-11-25 19:21:55]

xcode project change LGTM

[Dean McNamee, 2008-11-25 21:27:48]

Sent to the try servers

http://codereview.chromium.org/12407/diff/17/233
File base/build/base.vcproj (right):

http://codereview.chromium.org/12407/diff/17/233#newcode843
Line 843: </File>
These need to be tabs?

[Dean McNamee, 2008-11-25 23:12:38]

Fixed tabs and committed as r6006.

On 2008/11/25 21:27:48, Dean McNamee wrote:
> Sent to the try servers
> 
> http://codereview.chromium.org/12407/diff/17/233
> File base/build/base.vcproj (right):
> 
> http://codereview.chromium.org/12407/diff/17/233#newcode843
> Line 843: </File>
> These need to be tabs?

[Dean McNamee, 2008-11-25 23:49:57]

I committed and it turned out to have a ton of issues.  I think I've managed to
get through them.  You didn't add the new files to the windows scons.  You added
test_file_util.cc and not test_file_util_win.cc to the windows project files. 
There was a typo in test_file_util_win.cc, ScopedHandle is not in the win_util::
namespace, etc.

On 2008/11/25 23:12:38, Dean McNamee wrote:
> Fixed tabs and committed as r6006.
> 
> On 2008/11/25 21:27:48, Dean McNamee wrote:
> > Sent to the try servers
> > 
> > http://codereview.chromium.org/12407/diff/17/233
> > File base/build/base.vcproj (right):
> > 
> > http://codereview.chromium.org/12407/diff/17/233#newcode843
> > Line 843: </File>
> > These need to be tabs?