Issue 12406: Case independent back references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12406: Case independent back references. (Closed)

Created:
12 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/regexp2000/

Visibility:
Public.

Description

Case independent back references.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -10 lines)			Patch
M	src/assembler-irregexp.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler-irregexp.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/bytecodes-irregexp.h	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/interpreter-irregexp.cc	View	3 chunks	+36 lines, -0 lines	1 comment	Download
M	src/jsregexp.cc	View	1 chunk	+6 lines, -1 line	1 comment	Download
M	src/regexp-macro-assembler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years ago (2008-11-25 08:18:45 UTC) #2

Lgtm.

http://codereview.chromium.org/12406/diff/1/7
File src/interpreter-irregexp.cc (right):

http://codereview.chromium.org/12406/diff/1/7#newcode45
Line 45: static bool BackRefMatchesNoCase(int from,
If we were concerned about performance we could consider comparing compares
old_char and new_char before canonicalization, as an expected fast case.

http://codereview.chromium.org/12406/diff/1/10
File src/jsregexp.cc (right):

http://codereview.chromium.org/12406/diff/1/10#newcode1477
Line 1477: if (!compiler->is_case_independent()) {
Why negate the condition?

Expand Messages | Collapse Messages