Linux: fix icon theme double free on shutdown....

Linux: fix icon theme double free on shutdown by eliminating dupes from icon theme array.

Simplify some code in DownloadItemGtk that I previously thought was related to the crash, and so had made complicated.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18222

[Lei Zhang, 2009-06-11 19:52:14]

http://codereview.chromium.org/124001/diff/1/3
File base/mime_util_linux.cc (right):

http://codereview.chromium.org/124001/diff/1/3#newcode549
Line 549: }
Can we do the duplication removal at the end of InitDefaultThemes() instead? So
when we search for themes, we don't search the duplicates multiple times.

[Evan Stade, 2009-06-11 20:36:00]

http://codereview.chromium.org/124001/diff/1/3
File base/mime_util_linux.cc (right):

http://codereview.chromium.org/124001/diff/1/3#newcode549
Line 549: }
On 2009/06/11 19:52:14, Lei Zhang wrote:
> Can we do the duplication removal at the end of InitDefaultThemes() instead?
So
> when we search for themes, we don't search the duplicates multiple times.

Done.

[Lei Zhang, 2009-06-11 21:19:36]

LGTM

[Lei Zhang, 2009-06-11 21:20:05]

though the commit log entry should be updated.

[Evan Stade, 2009-06-11 21:49:13]

hm? the description still looks accurate to me...

[dank, 2009-06-11 21:56:26]

is this http://crbug.com/13927 ?

[Lei Zhang, 2009-06-11 22:12:42]

I was thinking "remove duplicate icon themes".