Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1239002: Fix some gyp errors found with --check. (Closed)

Created:
10 years, 9 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Fix some gyp errors found with --check. Running check will error out until NaCl problems are fixed (CL pending). TEST=src/build/gyp_chromium --check Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/common.gypi View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
10 years, 9 months ago (2010-03-24 04:59:10 UTC) #1
Mark Mentovai
10 years, 9 months ago (2010-03-24 15:17:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698