Avoid calling ExecuteCode() on a NULL TabContents. The problem was an extra s...

chrome/browser/extensions/execute_code_in_tab_function.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/execute_code_in_tab_function.h"
 
 #include "base/callback.h"
 #include "base/string_util.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/extensions/extension_tabs_module.h"
@@ skipping 110 matching lines @@
         WideToUTF8(resource_.relative_path().value()));
 #endif  // OS_WIN
     SendResponse(false);
   }
   Release();  // Balance the AddRef taken in RunImpl
 }
 
 bool ExecuteCodeInTabFunction::Execute(const std::string& code_string) {
   TabContents* contents = NULL;
   Browser* browser = NULL;
-  if (!ExtensionTabUtil::GetTabById(execute_tab_id_, profile(),
-                                    include_incognito(), &browser, NULL,
-                                    &contents, NULL) && contents && browser) {
+
+  bool success = ExtensionTabUtil::GetTabById(
+      execute_tab_id_, profile(), include_incognito(), &browser, NULL,
+      &contents, NULL) && contents && browser;
+
+  if (!success) {
     SendResponse(false);
     return false;
   }
 
   Extension* extension = GetExtension();
   if (!extension) {
     SendResponse(false);
     return false;
   }
 
@@ skipping 19 matching lines @@
 void ExecuteCodeInTabFunction::Observe(NotificationType type,
                                        const NotificationSource& source,
                                        const NotificationDetails& details) {
   std::pair<int, bool>* result_details =
       Details<std::pair<int, bool> >(details).ptr();
   if (result_details->first == request_id()) {
     SendResponse(result_details->second);
     Release();  // balanced in Execute()
   }
 }