Issue 1235001: linux: be more conservative in Liberation font fallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235001: linux: be more conservative in Liberation font fallback (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews

Visibility:
Public.

Description

linux: be more conservative in Liberation font fallback Rather than encoding all of the supposedly metric-compatible fonts from fontconfig, let's only whitelist fonts we know really improve the web for users. The Helvetica and Courier New substitutes don't look too great. BUB=39099 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42399

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -66 lines)			Patch
	M	skia/ext/SkFontHost_fontconfig_direct.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	skia/ext/SkFontHost_fontconfig_direct.cpp	View		2 chunks	+41 lines, -62 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

this should fix that other font fallback issue you were worried about as well

10 years, 9 months ago (2010-03-23 23:12:41 UTC) #1

LGTM

Thanks!

Expand Messages | Collapse Messages