Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1234001: autotest: Make netperf2 cross compile (Closed)

Created:
10 years, 9 months ago by Kenneth Waters
Modified:
9 years, 7 months ago
Reviewers:
robotboy, ericli
CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, sosa
Visibility:
Public.

Description

autotest: Make netperf2 cross compile - Switch to configure wrapper function TEST=Built for arm-generic and x86-generic Bug=None

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move configure() to utils. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M client/deps/sysstat/sysstat.py View 1 1 chunk +1 line, -1 line 0 comments Download
M client/tests/netperf2/netperf2.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Kenneth Waters
10 years, 9 months ago (2010-03-23 23:13:21 UTC) #1
ericli
http://codereview.chromium.org/1234001/diff/1/2 File client/deps/sysstat/sysstat.py (right): http://codereview.chromium.org/1234001/diff/1/2#newcode17 client/deps/sysstat/sysstat.py:17: self.configure('--prefix=%s' % topdir) sorry, I think I should be ...
10 years, 9 months ago (2010-03-23 23:51:40 UTC) #2
Kenneth Waters
I switched back to utils, ptal.
10 years, 9 months ago (2010-03-24 00:48:18 UTC) #3
ericli
10 years, 9 months ago (2010-03-24 01:08:15 UTC) #4
LGTM.

On 2010/03/24 00:48:18, Kenneth Waters wrote:
> I switched back to utils, ptal.

Powered by Google App Engine
This is Rietveld 408576698