Issue 1233003: Speed up conversion of untagged int32 result if we know it must be a smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233003: Speed up conversion of untagged int32 result if we know it must be a smi. (Closed)

Created:
10 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Speed up conversion of untagged int32 result if we know it must be a smi. Committed: http://code.google.com/p/v8/source/detail?r=4273

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -1 line)			Patch
M	src/ast.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ast.cc	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 2	3 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

10 years, 9 months ago (2010-03-25 11:38:40 UTC) #2

LGTM.

http://codereview.chromium.org/1233003/diff/3002/6004
File src/ast.cc (right):

http://codereview.chromium.org/1233003/diff/3002/6004#newcode198
src/ast.cc:198: if (op == Token::BIT_OR && ((value & 0xC0000000) == 0xC0000000))
{
The common style in V8 seems to be using lowercase letters for hexadecimal
constants.

http://codereview.chromium.org/1233003/diff/3002/6004#newcode202
src/ast.cc:202: if (op == Token::BIT_AND && ((value & 0xC0000000) ==
0x00000000)) {
For zero I'd always write 0 instead of 0x00000000.

Expand Messages | Collapse Messages