Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 123015: Add .fragment and .sigs to non-compiliable suffixes. (Closed)

Created:
11 years, 6 months ago by Craig Schlenter
Modified:
9 years, 7 months ago
Reviewers:
awong, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add .fragment and .sigs to non-compilable suffixes. This fixes the shared build on Linux after r18122. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M site_scons/site_tools/chromium_builders.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Craig Schlenter
I'm not sure if this is the right way of fixing this but it appears ...
11 years, 6 months ago (2009-06-11 12:21:02 UTC) #1
sgk
lgtm
11 years, 6 months ago (2009-06-11 13:45:14 UTC) #2
awong
LGTM
11 years, 6 months ago (2009-06-11 20:00:20 UTC) #3
Craig Schlenter
11 years, 6 months ago (2009-06-12 18:40:27 UTC) #4
On 2009/06/11 20:00:20, awong wrote:
> LGTM

Thank you! Can someone land this for me please? I have to do a fresh checkout
over a really slow link before my machine will be in shape to commit. Otherwise
I'll push it in after my machine is back in shape ...

Powered by Google App Engine
This is Rietveld 408576698