Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 123014: Add x64 implementation test support for assembler and code generator. (Closed)

Created:
11 years, 6 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Add x64 implementation test support for assembler and code generator. Committed: http://code.google.com/p/v8/source/detail?r=2141

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 2 chunks +29 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
11 years, 6 months ago (2009-06-11 09:19:28 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/123014/diff/1/2 File src/bootstrapper.cc (right): http://codereview.chromium.org/123014/diff/1/2#newcode1116 Line 1116: // TODO(X64): Reenable remaining initialization when code ...
11 years, 6 months ago (2009-06-11 09:34:29 UTC) #2
William Hesse
11 years, 6 months ago (2009-06-11 11:06:16 UTC) #3
http://codereview.chromium.org/123014/diff/1/5
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/123014/diff/1/5#newcode83
Line 83: } else {
On 2009/06/11 09:34:30, Lasse Reichstein wrote:
> Add an UNIMPLEMENTED() here until we have content.
> Or do a simple implementation like
>  masm->movq(rax,0x2a);
>  masm->ret();

Done.

http://codereview.chromium.org/123014/diff/1/3
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/123014/diff/1/3#newcode73
Line 73: masm.GetCode(&desc);
On 2009/06/11 09:34:30, Lasse Reichstein wrote:
> Add UNIMPLEMENTED() until it's implemented.
> 

I don't want this to fail.  It should pass safely, as more and more
functionality is added to it.

Powered by Google App Engine
This is Rietveld 408576698