Implement tick events compression in a log file.

src/log.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 285 matching lines @@
 
 //
 // Logger class implementation.
 //
 Ticker* Logger::ticker_ = NULL;
 Profiler* Logger::profiler_ = NULL;
 VMState* Logger::current_state_ = NULL;
 VMState Logger::bottom_state_(EXTERNAL);
 SlidingStateWindow* Logger::sliding_state_window_ = NULL;
 const char** Logger::log_events_ = NULL;
+int Logger::tick_repeat_count_ = 0;
 
 #define DECLARE_LONG_EVENT(ignore1, long_name, ignore2) long_name,
 const char* kLongLogEventsNames[Logger::NUMBER_OF_LOG_EVENTS] = {
   LOG_EVENTS_AND_TAGS_LIST(DECLARE_LONG_EVENT)
 };
 #undef DECLARE_LONG_EVENT
 
 #define DECLARE_SHORT_EVENT(ignore1, ignore2, short_name) short_name,
 const char* kCompressedLogEventsNames[Logger::NUMBER_OF_LOG_EVENTS] = {
   LOG_EVENTS_AND_TAGS_LIST(DECLARE_SHORT_EVENT)
@@ skipping 525 matching lines @@
       prev_ptr = ptr;
       // To avoid printing negative offsets in an unsigned form,
       // we are printing an absolute value with a sign.
       const char sign = delta >= 0 ? '+' : '-';
       if (sign == '-') { delta = -delta; }
       msg.Append(",%c0x%" V8PRIxPTR, sign, delta);
     } else {
       msg.Append(",0x%" V8PRIxPTR, sample->stack[i]);
     }
   }
+  // In case if log compression is disabled, the flow is straightforward,
+  // because both StoreInCompressor and RetrieveCompressedPrevious do nothing
+  // and just return 'true'. Otherwise, to perform compression of repeated
+  // tick events, instead of the current event, the previous one is written.
+  if (!msg.StoreInCompressor()) {
+    // Current message repeats the previous one, don't write it.
+    ++tick_repeat_count_;

[Søren Thygesen Gjesse, 2009/06/11 11:13:56]

Maybe we want to report something once in a while even if events are the same
e.g after 1s (X repeated events depending on the sample interval)?

[Mikhail Naganov, 2009/06/11 14:07:12]

I think this is not needed. Overflow of a counter will only happen after about
24 days. Also, as I've noticed, in Chromium even idle application doesn't stuck
in the same place for a while. Every incoming event causes it to resume
execution, so PC or SP periodically changes.

+    return;
+  } else {
+    bool has_previous_message;
+    if (tick_repeat_count_ > 0) {
+      EmbeddedVector<char, 20> prefix;
+      OS::SNPrintF(prefix, "%s,%d,",
+                   log_events_[REPEAT_META_EVENT],
+                   tick_repeat_count_ + 1);
+      tick_repeat_count_ = 0;
+      has_previous_message = msg.RetrieveCompressedPrevious(prefix.start());
+    } else {
+      has_previous_message = msg.RetrieveCompressedPrevious();
+    }
+    if (!has_previous_message) return;
+  }
   msg.Append('\n');
   msg.WriteToLogFile();
 }
 
 
 bool Logger::IsProfilerPaused() {
   return profiler_->paused();
 }
 
 
@@ skipping 327 matching lines @@
     } else if (previous_->state_ == EXTERNAL) {
       // We are leaving V8.
       Heap::Protect();
     }
   }
 #endif
 }
 #endif
 
 } }  // namespace v8::internal