Issue 1225007: Don't allow drops on the omnibox for popup windows....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1225007: Don't allow drops on the omnibox for popup windows.... (Closed)

Created:
10 years, 9 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't allow drops on the omnibox for popup windows. BUG=33071 TEST=drags to omnibox in popup should be denied. drags to omnibox in normal window should be allowed and load the url. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42753

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/cocoa/autocomplete_text_field.mm	View		3 chunks	+8 lines, -3 lines	0 comments	Download
	M	chrome/browser/cocoa/autocomplete_text_field_editor.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

10 years, 9 months ago (2010-03-25 14:40:32 UTC) #2

LGTM

I've been a little scared of using browserWindowControllerForView: in
non-bar-visibility-related situations, because the static method adds a weird
dependency that's hard to mock out in tests.  In this case, you're shortening
code that already did the exact same thing, so I'm fine with it, but we should
decide whether or not my fears are warranted.

Expand Messages | Collapse Messages