Issue 1222001: Fix Mac build packaging brokenness from r42357 due to a missing comma in chrome_dll.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222001: Fix Mac build packaging brokenness from r42357 due to a missing comma in chrome_dll.gypi. (Closed)

Created:
10 years, 9 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
Nico, eroman

CC:
chromium-reviews

Visibility:
Public.

Fix Mac build packaging brokenness from r42357 due to a missing comma in chrome_dll.gypi. BUG=39083 TEST=Clobber build and try to open the tab-based bookmark manager. Don't get a 404. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42386

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/chrome_dll.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

eroman

10 years, 9 months ago (2010-03-24 03:25:32 UTC) #3

LGTM, sorry about that!
(surprised I didn't get any complaints from gyp).