Inline keyed stores if the code is in a loop and the key is likely to...

Inline keyed stores if the code is in a loop and the key is likely to
be a smi.

The inlined version works for stores to JSArrays where the key is a
smi that is within bounds of the array and the value is either
constant or a smi so we can skip the write-barrier.

Committed: http://code.google.com/p/v8/source/detail?r=2144

[Kevin Millikin (Chromium), 2009-06-11 13:05:27]

Some comments to address, but after that LGTM.

http://codereview.chromium.org/122035/diff/13/15
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/122035/diff/13/15#newcode6039
Line 6039: #define __ ACCESS_MASM(cgen_->masm())
The other Reference member functions use ACCESS_MASM(masm) and make sure to
declare a local named masm before using __.

http://codereview.chromium.org/122035/diff/13/15#newcode6042
Line 6042: void Reference::SetValue(InitState init_state, bool
value_is_constant) {
Elements on the virtual frame know if they're compile-time constants (and it
catches more cases than just literals---we do some smi op folding and track
through simple assignments). The extra argument is not needed.

http://codereview.chromium.org/122035/diff/13/15#newcode6082
Line 6082: value.ToRegister();
Just before this you want

bool value_is_constant = value.is_constant();

http://codereview.chromium.org/122035/diff/13/15#newcode6138
Line 6138: cgen_->frame()->Push(receiver.reg(), receiver.static_type());
Use the VirtualFrame::Push(Result*) overloaded version to hand  ownership of the
result back to the frame (and avoid passing the static type explicitly).

[Mads Ager (chromium), 2009-06-11 13:10:57]

On 2009/06/11 13:05:27, Kevin Millikin wrote:
> Some comments to address, but after that LGTM.

Great comments, thanks.  All done.