chrome/browser/external_tab_container.cc - Issue 122027: Remove the Menu object, converting all the remaining callers to use Menu2. I'...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_tab_container.cc

Issue 122027: Remove the Menu object, converting all the remaining callers to use Menu2. I'... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/search_provider.cc ('k') | chrome/browser/tab_contents/render_view_context_menu_external_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_tab_container.cc

===================================================================

--- chrome/browser/external_tab_container.cc (revision 18306)

+++ chrome/browser/external_tab_container.cc (working copy)

@@ -4,6 +4,7 @@

#include "chrome/browser/external_tab_container.h"

+#include "app/l10n_util.h"

#include "app/win_util.h"

#include "base/logging.h"

#include "base/win_util.h"

@@ -268,17 +269,17 @@

external_context_menu_.reset(

new RenderViewContextMenuExternalWin(tab_contents(),

params,

- GetNativeView(),

disabled_context_menu_ids_));

external_context_menu_->Init();

POINT screen_pt = { params.x, params.y };

MapWindowPoints(GetNativeView(), HWND_DESKTOP, &screen_pt, 1);

+ bool rtl = l10n_util::TextDirection() == l10n_util::RIGHT_TO_LEFT;

automation_->Send(

new AutomationMsg_ForwardContextMenuToExternalHost(0, tab_handle_,

external_context_menu_->GetMenuHandle(), screen_pt.x, screen_pt.y,

- external_context_menu_->GetTPMAlignFlags()));

+ rtl ? TPM_RIGHTALIGN : TPM_LEFTALIGN));

return true;

}