Remove the Menu object, converting all the remaining callers to use Menu2. I'...

chrome/browser/views/toolbar_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/toolbar_view.h"
 
 #include <string>
 
 #include "app/drag_drop_types.h"
 #include "app/gfx/canvas.h"
@@ skipping 153 matching lines @@
       home_(NULL),
       star_(NULL),
       location_bar_(NULL),
       go_(NULL),
       page_menu_(NULL),
       app_menu_(NULL),
       bookmark_menu_(NULL),
       profile_(NULL),
       browser_(browser),
       tab_(NULL),
-      profiles_menu_(NULL),
-      profiles_helper_(new GetProfilesHelper(this)) {
+      profiles_menu_contents_(NULL),
+      ALLOW_THIS_IN_INITIALIZER_LIST(
+          profiles_helper_(new GetProfilesHelper(this))) {
   browser_->command_updater()->AddCommandObserver(IDC_BACK, this);
   browser_->command_updater()->AddCommandObserver(IDC_FORWARD, this);
   browser_->command_updater()->AddCommandObserver(IDC_RELOAD, this);
   browser_->command_updater()->AddCommandObserver(IDC_HOME, this);
   browser_->command_updater()->AddCommandObserver(IDC_STAR, this);
   back_menu_model_.reset(new BackForwardMenuModelViews(
       browser, BackForwardMenuModel::BACKWARD_MENU_DELEGATE));
   forward_menu_model_.reset(new BackForwardMenuModelViews(
       browser, BackForwardMenuModel::FORWARD_MENU_DELEGATE));
   if (browser->type() == Browser::TYPE_NORMAL)
@@ skipping 60 matching lines @@
   }
   // Returns the next available button index, or if no button is available in
   // the specified direction, remains where it was.
   return view_index;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ToolbarView, Menu::BaseControllerDelegate overrides:
 
 bool ToolbarView::GetAcceleratorInfo(int id, views::Accelerator* accel) {
-  // The standard Ctrl-X, Ctrl-V and Ctrl-C are not defined as accelerators
-  // anywhere so we need to check for them explicitly here.
-  // TODO(cpu) Bug 1109102. Query WebKit land for the actual bindings.
-  switch (id) {
-    case IDC_CUT:
-      *accel = views::Accelerator(L'X', false, true, false);
-      return true;
-    case IDC_COPY:
-      *accel = views::Accelerator(L'C', false, true, false);
-      return true;
-    case IDC_PASTE:
-      *accel = views::Accelerator(L'V', false, true, false);
-      return true;
-  }
-  // Else, we retrieve the accelerator information from the frame.
   return GetWidget()->GetAccelerator(id, accel);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ToolbarView, views::MenuDelegate implementation:
 
 void ToolbarView::RunMenu(views::View* source, const gfx::Point& pt,
                           gfx::NativeView parent) {
   switch (source->GetID()) {
     case VIEW_ID_PAGE_MENU:
       RunPageMenu(pt, parent);
       break;
     case VIEW_ID_APP_MENU:
       RunAppMenu(pt, parent);
       break;
     default:
       NOTREACHED() << "Invalid source menu.";
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ToolbarView, GetProfilesHelper::Delegate implementation:
 
 void ToolbarView::OnGetProfilesDone(
     const std::vector<std::wstring>& profiles) {
   // Nothing to do if the menu has gone away.
-  if (!profiles_menu_)
+  if (!profiles_menu_contents_.get())
     return;
 
   // Store the latest list of profiles in the browser.
   browser_->set_user_data_dir_profiles(profiles);
 
   // Add direct sub menu items for profiles.
   std::vector<std::wstring>::const_iterator iter = profiles.begin();
   for (int i = IDC_NEW_WINDOW_PROFILE_0;
        (i <= IDC_NEW_WINDOW_PROFILE_LAST) && (iter != profiles.end());
        ++i, ++iter)
-    profiles_menu_->AppendMenuItemWithLabel(i, *iter);
+    profiles_menu_contents_->AddItem(i, *iter);
 
   // If there are more profiles then show "Other" link.
   if (iter != profiles.end()) {
-    profiles_menu_->AppendSeparator();
-    profiles_menu_->AppendMenuItemWithLabel(
-        IDC_SELECT_PROFILE, l10n_util::GetString(IDS_SELECT_PROFILE));
+    profiles_menu_contents_->AddSeparator();
+    profiles_menu_contents_->AddItemWithStringId(IDC_SELECT_PROFILE,
+                                                 IDS_SELECT_PROFILE);
   }
 
   // Always show a link to select a new profile.
-  profiles_menu_->AppendSeparator();
-  profiles_menu_->AppendMenuItemWithLabel(
+  profiles_menu_contents_->AddSeparator();
+  profiles_menu_contents_->AddItemWithStringId(
       IDC_NEW_PROFILE,
-      l10n_util::GetString(IDS_SELECT_PROFILE_DIALOG_NEW_PROFILE_ENTRY));
+      IDS_SELECT_PROFILE_DIALOG_NEW_PROFILE_ENTRY);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ToolbarView, LocationBarView::Delegate implementation:
 
 TabContents* ToolbarView::GetTabContents() {
   return tab_;
 }
 
 void ToolbarView::OnInputInProgress(bool in_progress) {
@@ skipping 729 matching lines @@
 
 void ToolbarView::CreateAppMenu() {
   if (app_menu_contents_.get())
     return;
 
   app_menu_contents_.reset(new views::SimpleMenuModel(this));
   app_menu_contents_->AddItemWithStringId(IDC_NEW_TAB, IDS_NEW_TAB);
   app_menu_contents_->AddItemWithStringId(IDC_NEW_WINDOW, IDS_NEW_WINDOW);
   app_menu_contents_->AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW,
                                           IDS_NEW_INCOGNITO_WINDOW);
+  // Enumerate profiles asynchronously and then create the parent menu item.
+  // We will create the child menu items for this once the asynchronous call is
+  // done.  See OnGetProfilesDone().
+  const CommandLine& command_line = *CommandLine::ForCurrentProcess();
+  if (command_line.HasSwitch(switches::kEnableUserDataDirProfiles)) {
+    profiles_helper_->GetProfiles(NULL);
+    profiles_menu_contents_.reset(new views::SimpleMenuModel(this));
+    app_menu_contents_->AddSubMenuWithStringId(IDS_PROFILE_MENU,
+                                               profiles_menu_contents_.get());
+  }
+
   app_menu_contents_->AddSeparator();
   app_menu_contents_->AddCheckItemWithStringId(IDC_SHOW_BOOKMARK_BAR,
                                                IDS_SHOW_BOOKMARK_BAR);
   app_menu_contents_->AddItemWithStringId(IDC_FULLSCREEN, IDS_FULLSCREEN);
   app_menu_contents_->AddSeparator();
   app_menu_contents_->AddItemWithStringId(IDC_SHOW_HISTORY, IDS_SHOW_HISTORY);
   app_menu_contents_->AddItemWithStringId(IDC_SHOW_BOOKMARK_MANAGER,
                                           IDS_BOOKMARK_MANAGER);
   app_menu_contents_->AddItemWithStringId(IDC_SHOW_DOWNLOADS,
                                           IDS_SHOW_DOWNLOADS);
@@ skipping 17 matching lines @@
   app_menu_contents_->AddItem(IDC_ABOUT,
                               l10n_util::GetStringF(
                                   IDS_ABOUT,
                                   l10n_util::GetString(IDS_PRODUCT_NAME)));
   app_menu_contents_->AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE);
   app_menu_contents_->AddSeparator();
   app_menu_contents_->AddItemWithStringId(IDC_EXIT, IDS_EXIT);
 
   app_menu_menu_.reset(new views::Menu2(app_menu_contents_.get()));
 }