Remove the Menu object, converting all the remaining callers to use Menu2. I'...

chrome/browser/autocomplete/autocomplete_edit_view_win.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit_view_win.h"
 
 #include <locale>
 
 #include "app/gfx/canvas.h"
 #include "app/l10n_util.h"
@@ skipping 23 matching lines @@
 #include "chrome/browser/search_engines/template_url_model.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/views/location_bar_view.h"
 #include "chrome/common/gfx/utils.h"
 #include "chrome/common/notification_service.h"
 #include "googleurl/src/url_util.h"
 #include "grit/generated_resources.h"
 #include "skia/ext/skia_utils_win.h"
 #include "views/drag_utils.h"
 #include "views/focus/focus_util_win.h"
+#include "views/widget/widget.h"
 
 #pragma comment(lib, "oleacc.lib")  // Needed for accessibility support.
 
 ///////////////////////////////////////////////////////////////////////////////
 // AutocompleteEditModel
 
 // A single AutocompleteController used solely for making synchronous calls to
 // determine how to deal with the clipboard contents for Paste And Go
 // functionality.  We avoid using the popup's controller here because we don't
 // want to interrupt in-progress queries or modify the popup state just
@@ skipping 407 matching lines @@
   ::ReleaseDC(NULL, dc);
 
   // Set the default character style -- adjust to our desired baseline and make
   // text grey.
   CHARFORMAT cf = {0};
   cf.dwMask = CFM_OFFSET | CFM_COLOR;
   cf.yOffset = -font_y_adjustment_ * kTwipsPerPixel;
   cf.crTextColor = GetSysColor(COLOR_GRAYTEXT);
   SetDefaultCharFormat(cf);
 
-  // Set up context menu.
-  context_menu_.reset(views::Menu::Create(this, views::Menu::TOPLEFT, m_hWnd));
-  if (popup_window_mode_) {
-    context_menu_->AppendMenuItemWithLabel(IDS_COPY,
-                                           l10n_util::GetString(IDS_COPY));
-  } else {
-    context_menu_->AppendMenuItemWithLabel(IDS_UNDO,
-                                           l10n_util::GetString(IDS_UNDO));
-    context_menu_->AppendSeparator();
-    context_menu_->AppendMenuItemWithLabel(IDS_CUT,
-                                           l10n_util::GetString(IDS_CUT));
-    context_menu_->AppendMenuItemWithLabel(IDS_COPY,
-                                           l10n_util::GetString(IDS_COPY));
-    context_menu_->AppendMenuItemWithLabel(IDS_PASTE,
-                                           l10n_util::GetString(IDS_PASTE));
-    // GetContextualLabel() will override this next label with the
-    // IDS_PASTE_AND_SEARCH label as needed.
-    context_menu_->AppendMenuItemWithLabel(
-        IDS_PASTE_AND_GO, l10n_util::GetString(IDS_PASTE_AND_GO));
-    context_menu_->AppendSeparator();
-    context_menu_->AppendMenuItemWithLabel(
-        IDS_SELECT_ALL, l10n_util::GetString(IDS_SELECT_ALL));
-    context_menu_->AppendSeparator();
-    context_menu_->AppendMenuItemWithLabel(
-        IDS_EDIT_SEARCH_ENGINES, l10n_util::GetString(IDS_EDIT_SEARCH_ENGINES));
-  }
-
   // By default RichEdit has a drop target. Revoke it so that we can install our
   // own. Revoke takes care of deleting the existing one.
   RevokeDragDrop(m_hWnd);
 
   // Register our drop target. RichEdit appears to invoke RevokeDropTarget when
   // done so that we don't have to explicitly.
   if (!popup_window_mode_) {
     scoped_refptr<EditDropTarget> drop_target = new EditDropTarget(this);
     RegisterDragDrop(m_hWnd, drop_target.get());
   }
@@ skipping 439 matching lines @@
   if (msg == WM_CAPTURECHANGED) {
     SendMessage(msg, 0, NULL);
     return;
   }
 
   CPoint client_point(screen_point);
   ::MapWindowPoints(NULL, m_hWnd, &client_point, 1);
   SendMessage(msg, flags, MAKELPARAM(client_point.x, client_point.y));
 }
 
-bool AutocompleteEditViewWin::IsCommandEnabled(int id) const {
-  switch (id) {
+bool AutocompleteEditViewWin::IsCommandIdChecked(int command_id) const {
+  return false;
+}
+
+bool AutocompleteEditViewWin::IsCommandIdEnabled(int command_id) const {
+  switch (command_id) {
     case IDS_UNDO:         return !!CanUndo();
-    case IDS_CUT:          return !!CanCut();
-    case IDS_COPY:         return !!CanCopy();
-    case IDS_PASTE:        return !!CanPaste();
+    case IDC_CUT:          return !!CanCut();
+    case IDC_COPY:         return !!CanCopy();
+    case IDC_PASTE:        return !!CanPaste();
     case IDS_PASTE_AND_GO: return CanPasteAndGo(GetClipboardText());
     case IDS_SELECT_ALL:   return !!CanSelectAll();
     case IDS_EDIT_SEARCH_ENGINES:
       return command_updater_->IsCommandEnabled(IDC_EDIT_SEARCH_ENGINES);
     default:               NOTREACHED(); return false;
   }
 }
 
-bool AutocompleteEditViewWin::GetContextualLabel(int id,
-                                                 std::wstring* out) const {
-  if ((id != IDS_PASTE_AND_GO) ||
-      // No need to change the default IDS_PASTE_AND_GO label unless this is a
-      // search.
-      !model_->is_paste_and_search())
-    return false;
-
-  out->assign(l10n_util::GetString(IDS_PASTE_AND_SEARCH));
-  return true;
+bool AutocompleteEditViewWin::GetAcceleratorForCommandId(
+    int command_id,
+    views::Accelerator* accelerator) {
+  return parent_view_->GetWidget()->GetAccelerator(command_id, accelerator);
 }
 
-void AutocompleteEditViewWin::ExecuteCommand(int id) {
+bool AutocompleteEditViewWin::IsLabelForCommandIdDynamic(int command_id) const {
+  // No need to change the default IDS_PASTE_AND_GO label unless this is a
+  // search.
+  return command_id == IDS_PASTE_AND_GO;
+}
+
+std::wstring AutocompleteEditViewWin::GetLabelForCommandId(
+    int command_id) const {
+  DCHECK(command_id == IDS_PASTE_AND_GO);
+  return l10n_util::GetString(model_->is_paste_and_search() ?
+      IDS_PASTE_AND_SEARCH : IDS_PASTE_AND_GO);
+}
+
+void AutocompleteEditViewWin::ExecuteCommand(int command_id) {
   ScopedFreeze freeze(this, GetTextObjectModel());
-  if (id == IDS_PASTE_AND_GO) {
+  if (command_id == IDS_PASTE_AND_GO) {
     // This case is separate from the switch() below since we don't want to wrap
     // it in OnBefore/AfterPossibleChange() calls.
     model_->PasteAndGo();
     return;
   }
 
   OnBeforePossibleChange();
-  switch (id) {
+  switch (command_id) {
     case IDS_UNDO:
       Undo();
       break;
 
-    case IDS_CUT:
+    case IDC_CUT:
       Cut();
       break;
 
-    case IDS_COPY:
+    case IDC_COPY:
       Copy();
       break;
 
-    case IDS_PASTE:
+    case IDC_PASTE:
       Paste();
       break;
 
     case IDS_SELECT_ALL:
       SelectAll(false);
       break;
 
     case IDS_EDIT_SEARCH_ENGINES:
       command_updater_->ExecuteCommand(IDC_EDIT_SEARCH_ENGINES);
       break;
@@ skipping 149 matching lines @@
 
   if (ch == VK_TAB) {
     // Don't add tabs to the input.
     return;
   }
 
   HandleKeystroke(GetCurrentMessage()->message, ch, repeat_count, flags);
 }
 
 void AutocompleteEditViewWin::OnContextMenu(HWND window, const CPoint& point) {
+  BuildContextMenu();
   if (point.x == -1 || point.y == -1) {
     POINT p;
     GetCaretPos(&p);
     MapWindowPoints(HWND_DESKTOP, &p, 1);
-    context_menu_->RunMenuAt(p.x, p.y);
+    context_menu_->RunContextMenuAt(gfx::Point(p));
   } else {
-    context_menu_->RunMenuAt(point.x, point.y);
+    context_menu_->RunContextMenuAt(gfx::Point(point));
   }
 }
 
 void AutocompleteEditViewWin::OnCopy() {
   const std::wstring text(GetSelectedText());
   if (text.empty())
     return;
 
   ScopedClipboardWriter scw(g_browser_process->clipboard());
   scw.WriteText(text);
@@ skipping 1129 matching lines @@
 }
 
 void AutocompleteEditViewWin::RepaintDropHighlight(int position) {
   if ((position != -1) && (position <= GetTextLength())) {
     const POINT min_loc(PosFromChar(position));
     const RECT highlight_bounds = {min_loc.x - 1, font_y_adjustment_,
         min_loc.x + 2, font_ascent_ + font_descent_ + font_y_adjustment_};
     InvalidateRect(&highlight_bounds, false);
   }
 }
+
+void AutocompleteEditViewWin::BuildContextMenu() {
+  if (context_menu_contents_.get())
+    return;
+
+  context_menu_contents_.reset(new views::SimpleMenuModel(this));
+  // Set up context menu.
+  if (popup_window_mode_) {
+    context_menu_contents_->AddItemWithStringId(IDS_COPY, IDS_COPY);
+  } else {
+    context_menu_contents_->AddItemWithStringId(IDS_UNDO, IDS_UNDO);
+    context_menu_contents_->AddSeparator();
+    context_menu_contents_->AddItemWithStringId(IDC_CUT, IDS_CUT);
+    context_menu_contents_->AddItemWithStringId(IDC_COPY, IDS_COPY);
+    context_menu_contents_->AddItemWithStringId(IDC_PASTE, IDS_PASTE);
+    // GetContextualLabel() will override this next label with the
+    // IDS_PASTE_AND_SEARCH label as needed.
+    context_menu_contents_->AddItemWithStringId(IDS_PASTE_AND_GO,
+                                                IDS_PASTE_AND_GO);
+    context_menu_contents_->AddSeparator();
+    context_menu_contents_->AddItemWithStringId(IDS_SELECT_ALL, IDS_SELECT_ALL);
+    context_menu_contents_->AddSeparator();
+    context_menu_contents_->AddItemWithStringId(IDS_EDIT_SEARCH_ENGINES,
+                                                IDS_EDIT_SEARCH_ENGINES);
+  }
+  context_menu_.reset(new views::Menu2(context_menu_contents_.get()));
+}