Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: presubmit_support.py

Issue 122016: Melting pot of changes. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index 1368665ed6ba34c276a266bf2bffd71440e42681..fe7b94927e267560f71bb9c4880995d863dbd665 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -529,7 +529,7 @@ class GclChange(object):
for info in change_info.files
]
- def Change(self):
+ def Name(self):
"""Returns the change name."""
return self._name
@@ -547,15 +547,15 @@ class GclChange(object):
return self._full_description
def RepositoryRoot(self):
- """Returns the repository root for this change, as an absolute path."""
+ """Returns the repository (checkout) root directory for this change,
+ as an absolute path.
+ """
return self._repository_root
def __getattr__(self, attr):
- """Return keys directly as attributes on the object.
-
- You may use a friendly name (from SPECIAL_KEYS) or the actual name of
- the key.
- """
+ """Return tags directly as attributes on the object."""
+ if not re.match(r"^[A-Z_]*$", attr):
+ raise AttributeError(self, attr)
return self.tags.get(attr)
def AffectedFiles(self, include_dirs=False, include_deletes=True):
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698