Melting pot of changes.

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 import exceptions
 import random
 import string
@@ skipping 192 matching lines @@
             {'URL': 'svn:/foo/boo/flap.h'})
     presubmit.gcl.ReadFile(blat).AndReturn('boo!\nahh?')
     presubmit.gcl.ReadFile(notfound).AndReturn('look!\nthere?')
     self.mox.ReplayAll()
 
     ci = presubmit.gcl.ChangeInfo(name='mychange', issue=0, patchset=0,
                                   description='\n'.join(description_lines),
                                   files=files)
     change = presubmit.GclChange(ci)
 
-    self.failUnless(change.Change() == 'mychange')
+    self.failUnless(change.Name() == 'mychange')
     self.failUnless(change.DescriptionText() ==
                     'Hello there\nthis is a change\nand some more regular text')
     self.failUnless(change.FullDescriptionText() ==
                     '\n'.join(description_lines))
 
     self.failUnless(change.BUG == '123')
     self.failUnless(change.STORY == 'http://foo/')
 
     self.failUnless(len(change.AffectedFiles()) == 4)
     self.failUnless(len(change.AffectedFiles(include_dirs=True)) == 5)
@@ skipping 250 matching lines @@
 
     affected_files = change.AffectedFiles(include_dirs=False)
     self.failUnless(len(affected_files) == 1)
     self.failUnless(affected_files[0].LocalPath().endswith('blat.cc'))
     affected_files_and_dirs = change.AffectedFiles(include_dirs=True)
     self.failUnless(len(affected_files_and_dirs) == 2)
 
   def testTags(self):
     DEFAULT_SCRIPT = """
 def CheckChangeOnUpload(input_api, output_api):
- if input_api.change.tags['BUG'] != 'boo':
-   return [output_api.PresubmitError('Tag parsing failed. 1')]
- if input_api.change.tags['STORY'] != 'http://tracker.com/42':
-   return [output_api.PresubmitError('Tag parsing failed. 2')]
- if input_api.change.BUG != 'boo':
-   return [output_api.PresubmitError('Tag parsing failed. 6')]
- if input_api.change.STORY != 'http://tracker.com/42':
-   return [output_api.PresubmitError('Tag parsing failed. 7')]
- if 'TEST' in input_api.change.tags:
-   return [output_api.PresubmitError('Tag parsing failed. 3')]
- if input_api.change.DescriptionText() != 'Blah Blah':
-   return [output_api.PresubmitError('Tag parsing failed. 4 ' + 
-                                     input_api.change.DescriptionText())]
- if (input_api.change.FullDescriptionText() !=
-     'Blah Blah\\n\\nSTORY=http://tracker.com/42\\nBUG=boo\\n'):
-   return [output_api.PresubmitError('Tag parsing failed. 5 ' +
-                                     input_api.change.FullDescriptionText())]
- return [output_api.PresubmitNotifyResult(input_api.change.tags['STORY'])]
+  if input_api.change.tags['BUG'] != 'boo':
+    return [output_api.PresubmitError('Tag parsing failed. 1')]
+  if input_api.change.tags['STORY'] != 'http://tracker.com/42':
+    return [output_api.PresubmitError('Tag parsing failed. 2')]
+  if input_api.change.BUG != 'boo':
+    return [output_api.PresubmitError('Tag parsing failed. 6')]
+  if input_api.change.STORY != 'http://tracker.com/42':
+    return [output_api.PresubmitError('Tag parsing failed. 7')]
+  try:
+    y = False
+    x = input_api.change.invalid
+  except AttributeError:
+    y = True
+  if not y:
+    return [output_api.PresubmitError('Tag parsing failed. 8')]
+  if 'TEST' in input_api.change.tags:
+    return [output_api.PresubmitError('Tag parsing failed. 3')]
+  if input_api.change.DescriptionText() != 'Blah Blah':
+    return [output_api.PresubmitError('Tag parsing failed. 4 ' + 
+                                      input_api.change.DescriptionText())]
+  if (input_api.change.FullDescriptionText() !=
+      'Blah Blah\\n\\nSTORY=http://tracker.com/42\\nBUG=boo\\n'):
+    return [output_api.PresubmitError('Tag parsing failed. 5 ' +
+                                      input_api.change.FullDescriptionText())]
+  return [output_api.PresubmitNotifyResult(input_api.change.tags['STORY'])]
 def CheckChangeOnCommit(input_api, output_api):
   raise Exception("Test error")
 """
     self.mox.ReplayAll()
 
     change = presubmit.gcl.ChangeInfo(
         name='foo',
         issue=0,
         patchset=0,
         description="Blah Blah\n\nSTORY=http://tracker.com/42\nBUG=boo\n",
@@ skipping 388 matching lines @@
 
     output = filter(lambda x: x.IsTextFile(), list)
     self.failUnless(len(output) == 1)
     self.failUnless(list[0] == output[0])
 
 
 class GclChangeUnittest(PresubmitTestsBase):
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
-        'AbsoluteLocalPaths', 'AffectedFiles', 'AffectedTextFiles', 'Change',
-        'DescriptionText', 'FullDescriptionText', 'LocalPaths',
+        'AbsoluteLocalPaths', 'AffectedFiles', 'AffectedTextFiles',
+        'DescriptionText', 'FullDescriptionText', 'LocalPaths', 'Name',
         'RepositoryRoot', 'RightHandSideLines', 'ServerPaths',
         'issue', 'patchset', 'tags',
     ]
     # If this test fails, you should add the relevant test.
     ci = presubmit.gcl.ChangeInfo('', 0, 0, '', None)
     self.compareMembers(presubmit.GclChange(ci, self.fake_root_dir), members)
 
 
 class CannedChecksUnittest(PresubmitTestsBase):
   """Tests presubmit_canned_checks.py."""
@@ skipping 385 matching lines @@
     test_result.errors = 0
     self.mox.ReplayAll()
 
     results = presubmit_canned_checks.RunPythonUnitTests(
         input_api, presubmit.OutputApi, ['test_module'])
     self.assertEquals(len(results), 0)
 
 
 if __name__ == '__main__':
   unittest.main()