Moving the WM_SETFOCUS message processing out of FocusManager

Changing the focus manager to not subclass HWNDs (but for the top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18301

[jcampan, 2009-06-11 05:36:33]

Sorry for the big review.

Note that I could not removed the native_tab_contents_container just yet.  It'll
go when I port the focus manager to Linux.

[Ben Goodger (Google), 2009-06-11 21:42:56]

LGTM

http://codereview.chromium.org/122002/diff/60/1093
File chrome/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/122002/diff/60/1093#newcode672
Line 672: return;
why not just

if (view)
  view->GotFocus();

http://codereview.chromium.org/122002/diff/60/1090
File chrome/browser/tab_contents/tab_contents_view_win.cc (right):

http://codereview.chromium.org/122002/diff/60/1090#newcode249
Line 249: if (rwhv) {
maybe just:

::SetFocus(rwhv ? rwhv->GetNativeView() : GetNativeView());

[Evan Stade, 2009-06-12 21:29:59]

I don't think that we want the changes to *_gtk*. We don't use the focus
manager. Can you remove this extra cruft?