Computes the total size of the files in a directory...

Function to compute the total size of the files in a directory

We need this for the diagnostic mode but it can be used by others.
Did not see test for GetFileSize() so added them

BUG=none
TEST=ut included



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42540

[cpu_(ooo_6.6-7.5), 2010-03-24 00:59:35]

.

[sehr (please use chromium), 2010-03-24 20:30:47]

coding convention nits, one spelling nit, and a question.  Fix, and LGTM.

http://codereview.chromium.org/1220001/diff/10001/6003
File base/file_util.cc (right):

http://codereview.chromium.org/1220001/diff/10001/6003#newcode274
base/file_util.cc:274: for (FilePath current = file_iter.Next();
!current.empty(); current = file_iter.Next()) {
80 columns?

http://codereview.chromium.org/1220001/diff/10001/6003#newcode278
base/file_util.cc:278: LARGE_INTEGER li = {info.nFileSizeLow,
info.nFileSizeHigh};
aren't we supposed to have spaces after { and before }?

http://codereview.chromium.org/1220001/diff/10001/6004
File base/file_util_unittest.cc (right):

http://codereview.chromium.org/1220001/diff/10001/6004#newcode361
base/file_util_unittest.cc:361: // Create two files of 20 and 30 chars (utf8) in
lenght. ComputeDirectorySize
s/lenght/length/

http://codereview.chromium.org/1220001/diff/10001/6004#newcode379
base/file_util_unittest.cc:379: EXPECT_EQ(size_f1 + size_f2, computed_size);
Nit: Should you check what the computation does with a directory nested inside a
directory?

[cpu_(ooo_6.6-7.5), 2010-03-24 21:20:30]

thanks I'll commit when I can.

http://codereview.chromium.org/1220001/diff/10001/6003
File base/file_util.cc (right):

http://codereview.chromium.org/1220001/diff/10001/6003#newcode274
base/file_util.cc:274: for (FilePath current = file_iter.Next();
!current.empty(); current = file_iter.Next()) {
On 2010/03/24 20:30:47, sehr wrote:
> 80 columns?

Done.

http://codereview.chromium.org/1220001/diff/10001/6003#newcode278
base/file_util.cc:278: LARGE_INTEGER li = {info.nFileSizeLow,
info.nFileSizeHigh};
On 2010/03/24 20:30:47, sehr wrote:
> aren't we supposed to have spaces after { and before }?

I don't recall, I changed it in case.

[cpu_(ooo_6.6-7.5), 2010-03-24 21:21:14]

Also changed the test with one more nested directory level.


On 2010/03/24 21:20:30, cpu wrote:
> thanks I'll commit when I can.
> 
> http://codereview.chromium.org/1220001/diff/10001/6003
> File base/file_util.cc (right):
> 
> http://codereview.chromium.org/1220001/diff/10001/6003#newcode274
> base/file_util.cc:274: for (FilePath current = file_iter.Next();
> !current.empty(); current = file_iter.Next()) {
> On 2010/03/24 20:30:47, sehr wrote:
> > 80 columns?
> 
> Done.
> 
> http://codereview.chromium.org/1220001/diff/10001/6003#newcode278
> base/file_util.cc:278: LARGE_INTEGER li = {info.nFileSizeLow,
> info.nFileSizeHigh};
> On 2010/03/24 20:30:47, sehr wrote:
> > aren't we supposed to have spaces after { and before }?
> 
> I don't recall, I changed it in case.