Adds obscuring to credit card numbers when displayed....

Adds obscuring to credit card numbers when displayed.

xib change: added tag to fields that are used for credit card numbers.

BUG=http://crbug.com/38259
TEST=as in bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42768

[dhollowa, 2010-03-24 23:20:27]

http://codereview.chromium.org/1219009/diff/3001/4002
File chrome/browser/autofill/autofill_text_field_mac.mm (right):

http://codereview.chromium.org/1219009/diff/3001/4002#newcode31
chrome/browser/autofill/autofill_text_field_mac.mm:31: NSString* string =
object;
This logic should live next to CreditCard::PreviewSummary(), in
CreditCard::EditSummary(), say.  Ideally with additional unit test.

http://codereview.chromium.org/1219009/diff/3001/4002#newcode36
chrome/browser/autofill/autofill_text_field_mac.mm:36: [super
setObjectValue:starredString];
Are we sure that the starred-string is only used in the "view" and not the
"model"?  That is, we don't want the starred-string value flowing back into the
value passed out of the dialog and into the PersonalDataManager.  From my read
here, it looks like the AutoFillCreditCardModel's value is getting improperly
set.  Yes?

[Avi (use Gerrit), 2010-03-24 23:27:43]

http://codereview.chromium.org/1219009/diff/3001/4002
File chrome/browser/autofill/autofill_text_field_mac.mm (right):

http://codereview.chromium.org/1219009/diff/3001/4002#newcode31
chrome/browser/autofill/autofill_text_field_mac.mm:31: NSString* string =
object;
At this point in the flow, this view has no idea where the data is coming from,
as the bindings are setting things. Thoughts on how we can find the original
CreditCard from here?

http://codereview.chromium.org/1219009/diff/3001/4002#newcode36
chrome/browser/autofill/autofill_text_field_mac.mm:36: [super
setObjectValue:starredString];
Nope.

KVO will only kick in when the field confirms the edit. Since we force the
selection, any edit will clear. You can click around all you want and say "save"
but since no editing actually takes place, no updating happens.

[dhollowa, 2010-03-24 23:41:16]

http://codereview.chromium.org/1219009/diff/3001/4002
File chrome/browser/autofill/autofill_text_field_mac.mm (right):

http://codereview.chromium.org/1219009/diff/3001/4002#newcode31
chrome/browser/autofill/autofill_text_field_mac.mm:31: NSString* string =
object;
Sorry, I should have been clearer.  Was thinking you could create a temporary
CreditCard object, and then : 
creditCard.SetInfo(AutoFillType(CREDIT_CARD_NUMBER),
base::SysNSStringToUTF16(string))

Then pull the formatted string out of the temporary object.  This way, we have a
uniform cross-platform implementation of the string formatting.


On 2010/03/24 23:27:43, Avi wrote:
> At this point in the flow, this view has no idea where the data is coming
from,
> as the bindings are setting things. Thoughts on how we can find the original
> CreditCard from here?

http://codereview.chromium.org/1219009/diff/3001/4002#newcode36
chrome/browser/autofill/autofill_text_field_mac.mm:36: [super
setObjectValue:starredString];
Great, thanks for checking.

On 2010/03/24 23:27:43, Avi wrote:
> Nope.
> 
> KVO will only kick in when the field confirms the edit. Since we force the
> selection, any edit will clear. You can click around all you want and say
"save"
> but since no editing actually takes place, no updating happens.

[Avi (use Gerrit), 2010-03-25 14:33:59]

Updated and stuff.

[dhollowa, 2010-03-25 20:44:46]

LGTM.  Thanks for the refactor.

On 2010/03/25 14:33:59, Avi wrote:
> Updated and stuff.