Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1219002: linux: add a SlightHintedGeorgia font to test_shell (Closed)

Created:
10 years, 9 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

linux: add a SlightHintedGeorgia font to test_shell This is used by an upcoming layout test. Also make test_shell properly rebuild when you edit the fontconfig file. BUG=33447 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M webkit/tools/test_shell/resources/linux-fontconfig-config View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
10 years, 9 months ago (2010-03-23 21:55:42 UTC) #1
agl
LGTM
10 years, 9 months ago (2010-03-23 21:56:54 UTC) #2
agl
(p.s. grep for NonAntiAliasedSans in skia/ext/SkFontHost_fontconfig_direct.cpp)
10 years, 9 months ago (2010-03-23 21:58:59 UTC) #3
Evan Martin
On Tue, Mar 23, 2010 at 2:59 PM, <agl@chromium.org> wrote: > (p.s. grep for NonAntiAliasedSans ...
10 years, 9 months ago (2010-03-23 22:00:47 UTC) #4
agl
10 years, 9 months ago (2010-03-23 22:02:57 UTC) #5
On Tue, Mar 23, 2010 at 6:00 PM, Evan Martin <evan@chromium.org> wrote:
> Weird, why didn't I need something like this for my test?  I verified
> that twiddling stuff in the fontconfig file is properly modifying the
> font I get in the result...

I think I needed it... Certainly I *thought* that I needed it when I
wrote it, although I might just have tested it afterwards and fooled
myself with conformation bias.


AGL

Powered by Google App Engine
This is Rietveld 408576698