Issue 1217007: Fix conform test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1217007: Fix conform test. (Closed)

Created:
10 years, 9 months ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix conform test. Committed: http://code.google.com/p/v8/source/detail?r=4247

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	src/conversions.cc	View		6 chunks	+5 lines, -5 lines	0 comments	Download
	M	test/mjsunit/str-to-num.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/1217007/diff/1/2 File test/mjsunit/str-to-num.js (right): http://codereview.chromium.org/1217007/diff/1/2#newcode47 test/mjsunit/str-to-num.js:47: assertEquals(1, 1.); Maybe add an assertEquals(1, toNumber("1.")) too?

10 years, 9 months ago (2010-03-24 11:08:24 UTC) #2

SeRya

10 years, 9 months ago (2010-03-24 11:11:03 UTC) #3

http://codereview.chromium.org/1217007/diff/1/2
File test/mjsunit/str-to-num.js (right):

http://codereview.chromium.org/1217007/diff/1/2#newcode47
test/mjsunit/str-to-num.js:47: assertEquals(1, 1.);
On 2010/03/24 11:08:24, Kasper Lund wrote:
> Maybe add an assertEquals(1, toNumber("1.")) too?

Done.

Expand Messages | Collapse Messages

Issue 1217007: Fix conform test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages