Issue 1217003: Try to fix a compile error on ARM....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1217003: Try to fix a compile error on ARM.... (Closed)

Created:
10 years, 9 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
ukai

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Try to fix a compile error on ARM. This is a speculative change, to hopefully get the ARM builder compiling again. Lately it has been giving the error that |kHandshakeResponseMessage| is being used before it is initialized: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Arm/builds/2639/steps/compile/logs/stdio I don't know why it would say this, but perhaps it is getting confused by the multiple statics with the same name in this file. My proposed change removes the static keyword, to see if it has an effect. TBR=ukai Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42407

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	net/websockets/websocket_job_unittest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Seems like this did the trick! (Don't know why however)