Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2410)

Issue 1211001: Update enter_chroot.sh to exit with error messages when mount/unmount fails. (Closed)

Created:
10 years, 9 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
djmm, adlr
CC:
chromium-os-reviews_chromium.org, tedbo, sosa
Visibility:
Public.

Description

Update enter_chroot.sh to exit with error messages when mount/unmount fails. This is necessary for two reasons: 1) It's nice to get an error message when mount/unmount fails 2) set -e mode doesn't have any effect when you're in a subshell Note that these mount/unmount failures do happen regularly in development, so folks who depended on mount/umount failing silently will no longer be able to rely on this and will have to kill the mounts manually. Also fix subtle bugs in regexes for matching mount paths. (E.g. where the regex for $HOME/chroot also matches $HOME/chroot2). TEST=Tested mount/unmount with concurrently open shells. Tested mount/unmount when mount is being used by a process but the lock file does not reflect this. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M src/scripts/common.sh View 1 chunk +5 lines, -0 lines 0 comments Download
M src/scripts/enter_chroot.sh View 4 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davidjames
10 years, 9 months ago (2010-03-23 21:14:06 UTC) #1
adlr
LGTM
10 years, 9 months ago (2010-03-23 21:17:57 UTC) #2
djmm
LGTM
10 years, 9 months ago (2010-03-23 21:20:51 UTC) #3
djmm
10 years, 9 months ago (2010-03-23 21:23:01 UTC) #4
Can you add BUG=1788 to this.

Powered by Google App Engine
This is Rietveld 408576698