Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 121001: Update DEPS to pull in upstream change that removes RGBA32Buffer::bitmap(), a... (Closed)

Created:
11 years, 6 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update DEPS to pull in upstream changes that remove RGBA32Buffer::bitmap(), and rewrite local tests to compile. Also pulls in a change that upstreamed V8CustomBinding, since that got bracketed between my upstream changes; this includes the Chromium side of that too. This change exposed a deficiency in the XBM testing where we were erroneously using a zero-length set of image data to calculate the MD5 sum (because we were using the buffer rect instead of the image size, and the XBM decoder wasn't correctly setting the rect). Fixed the test to use the image size (which is more correct for this application), will fix the XBM decoder upstream to set the rect correctly. This in turn required generating new MD5 sums, which required patching the generation code (which is normally #ifdefed away) to also work with the past couple years of changes. This commit will need to land at the same time as one that updates the expected sums; during the period where either commit is in place without the other, the XBM decoding tests will fail. BUG=13633 TEST=Covered by unittests TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18131

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -859 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/glue/webdevtoolsclient_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/port/bindings/scripts/CodeGeneratorV8.pm View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/port/bindings/v8/NPV8Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/port/bindings/v8/v8_custom.h View 1 chunk +0 lines, -586 lines 0 comments Download
M webkit/port/bindings/v8/v8_custom.cpp View 1 chunk +0 lines, -245 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.h View 2 chunks +1 line, -1 line 0 comments Download
M webkit/port/bindings/v8/v8_proxy.cpp View 2 chunks +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.cc View 1 2 chunks +16 lines, -14 lines 0 comments Download
M webkit/webkit.gyp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
11 years, 6 months ago (2009-06-10 22:13:05 UTC) #1
Peter Kasting
Sigh. This fails to compile on Linux/Mac because I checked in broken code upstream (but ...
11 years, 6 months ago (2009-06-10 22:46:25 UTC) #2
Peter Kasting
Modified to include compile fix upstream. I expect Mac to still be broken until awong ...
11 years, 6 months ago (2009-06-11 00:37:55 UTC) #3
Peter Kasting
Submitted as TBR
11 years, 6 months ago (2009-06-11 01:09:52 UTC) #4
darin (slow to review)
11 years, 6 months ago (2009-06-11 06:46:54 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698