Issue 1207003: Implement support for reattaching a global object to a context. This...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1207003: Implement support for reattaching a global object to a context. This... (Closed)

Created:
10 years, 9 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implement support for reattaching a global object to a context. This can be used to use the same global object for different contexts at different points in time. Committed: http://code.google.com/p/v8/source/detail?r=4253

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -2 lines)			Patch
M	include/v8.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/bootstrapper.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		3 chunks	+81 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/1207003/diff/1/6 File src/bootstrapper.cc (right): http://codereview.chromium.org/1207003/diff/1/6#newcode315 src/bootstrapper.cc:315: Handle<JSObject> global = Handle<JSObject>::cast(global_object); Can't you make this ...

10 years, 9 months ago (2010-03-24 13:09:27 UTC) #2

Mads Ager (chromium)

10 years, 9 months ago (2010-03-24 13:13:26 UTC) #3

http://codereview.chromium.org/1207003/diff/1/6
File src/bootstrapper.cc (right):

http://codereview.chromium.org/1207003/diff/1/6#newcode315
src/bootstrapper.cc:315: Handle<JSObject> global =
Handle<JSObject>::cast(global_object);
On 2010/03/24 13:09:27, Erik Corry wrote:
> Can't you make this a Handle<JSGlobalProxy> right away?

Yes, I can.  Thanks!

Expand Messages | Collapse Messages