Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 1205001: Revert 42366 - Allow TabContentsDelegate classes to specify whether InfoBars ... (Closed)

Created:
10 years, 9 months ago by Jói
Modified:
9 years, 7 months ago
Reviewers:
Jói
CC:
chromium-reviews, brettw-cc_chromium.org, amit, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 42366 - Allow TabContentsDelegate classes to specify whether InfoBars are enabled. Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer. BUG=2444936 Patch contributed by ericdingle@google.com Original review at http://codereview.chromium.org/890005 TBR=joi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -160 lines) Patch
M chrome/browser/automation/automation_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container.h View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/external_tab_container.cc View 5 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 4 chunks +15 lines, -10 lines 0 comments Download
M chrome_frame/chrome_frame_npapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_npapi_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M chrome_frame/chrome_frame_plugin.h View 1 chunk +4 lines, -12 lines 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 6 chunks +7 lines, -66 lines 0 comments Download
M chrome_frame/test/chrome_frame_automation_mock.h View 5 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jói
10 years, 9 months ago (2010-03-23 20:50:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698