Issue 119437: Display the actual tree status when the tree is closed. Much more helpful....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119437: Display the actual tree status when the tree is closed. Much more helpful.... (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Display the actual tree status when the tree is closed. Much more helpful. TEST=Try committing when the tree is closed to see. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18125

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+32 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

I personally like when error messages are predictable. I'm not sure we need to see ...

11 years, 6 months ago (2009-06-10 20:59:13 UTC) #2

M-A Ruel

11 years, 6 months ago (2009-06-10 21:02:34 UTC) #3

On 2009/06/10 20:59:13, Nicolas Sylvain wrote:
> I personally like when error messages are predictable. I'm not sure we need to
> see the tree comment in that error message.
> 
> That said, the code looks good, so I will LGTM it.

It shows reason, ETA, culprit, etc without having to look it up elsewhere.

Expand Messages | Collapse Messages