presubmit_canned_checks.py - Issue 119433: Add the default parameter to CheckChangeSvnEolStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 119433: Add the default parameter to CheckChangeSvnEolStyle. (Closed)

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 84d7f8e0c13eb8f07a82a33227b75e16ca792dde..6b3a4eed2c9c0793e3cca47b544c72490f3b4db6 100755

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -119,7 +119,7 @@ def CheckLongLines(input_api, output_api, maxlen=80, source_file_filter=None):

return []

-def CheckChangeSvnEolStyle(input_api, output_api, source_file_filter):

+def CheckChangeSvnEolStyle(input_api, output_api, source_file_filter=None):

"""Checks that the source files have svn:eol-style=LF."""

bad = filter(lambda f: f.scm == 'svn' and f.Property('svn:eol-style') != 'LF',

input_api.AffectedSourceFiles(source_file_filter))

« no previous file with comments | « no previous file | no next file » | no next file with comments »