Issue 119432: Use new canned checks in PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119432: Use new canned checks in PRESUBMIT.py (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use new canned checks in PRESUBMIT.py Also fix gcl presubmit tree status check when the change hasn't been uploaded nor gcl try'ed. Remove PRESUBMIT_unittest.py since it's not useful anymore. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18124

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -207 lines)			Patch
	M	PRESUBMIT.py	View	1 2	2 chunks	+34 lines, -101 lines	0 comments	Download
	D	PRESUBMIT_unittest.py	View		1 chunk	+0 lines, -106 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

im just going to rubber stamp this.

Expand Messages | Collapse Messages