Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: skia/ext/vector_canvas_unittest.cc

Issue 119430: Update webkit to r44571 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | webkit/tools/layout_tests/test_expectations.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/vector_canvas_unittest.cc
===================================================================
--- skia/ext/vector_canvas_unittest.cc (revision 18070)
+++ skia/ext/vector_canvas_unittest.cc (working copy)
@@ -317,14 +317,16 @@
}
}
-void LoadPngFileToSkBitmap(const std::wstring& filename, SkBitmap* bitmap) {
+void LoadPngFileToSkBitmap(const std::wstring& filename,
+ SkBitmap* bitmap,
+ bool is_opaque) {
Vector<char> compressed;
ReadFileToVector(filename, &compressed);
EXPECT_TRUE(compressed.size());
WebCore::PNGImageDecoder decoder;
decoder.setData(WebCore::SharedBuffer::adoptVector(compressed).get(), true);
*bitmap = decoder.frameBufferAtIndex(0)->bitmap();
- EXPECT_FALSE(bitmap->isOpaque());
+ EXPECT_EQ(is_opaque, bitmap->isOpaque());
Premultiply(*bitmap);
}
@@ -793,7 +795,7 @@
TEST_F(VectorCanvasTest, Bitmaps) {
{
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"bitmap_opaque.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"bitmap_opaque.png"), &bitmap, true);
vcanvas_->drawBitmap(bitmap, 13, 3, NULL);
pcanvas_->drawBitmap(bitmap, 13, 3, NULL);
EXPECT_EQ(0., ProcessImage(L"opaque"));
@@ -801,7 +803,7 @@
{
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"bitmap_alpha.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"bitmap_alpha.png"), &bitmap, false);
vcanvas_->drawBitmap(bitmap, 5, 15, NULL);
pcanvas_->drawBitmap(bitmap, 5, 15, NULL);
EXPECT_EQ(0., ProcessImage(L"alpha"));
@@ -810,7 +812,8 @@
TEST_F(VectorCanvasTest, ClippingRect) {
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap,
+ true);
SkRect rect;
rect.fLeft = 2;
rect.fTop = 2;
@@ -826,7 +829,8 @@
TEST_F(VectorCanvasTest, ClippingPath) {
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap,
+ true);
SkPath path;
path.addCircle(20, 20, 10);
vcanvas_->clipPath(path);
@@ -839,7 +843,8 @@
TEST_F(VectorCanvasTest, ClippingCombined) {
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap,
+ true);
SkRect rect;
rect.fLeft = 2;
@@ -860,7 +865,8 @@
TEST_F(VectorCanvasTest, ClippingIntersect) {
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap,
+ true);
SkRect rect;
rect.fLeft = 2;
@@ -881,7 +887,8 @@
TEST_F(VectorCanvasTest, ClippingClean) {
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap,
+ true);
{
SkRegion old_region(pcanvas_->getTotalClip());
SkRect rect;
@@ -908,7 +915,8 @@
TEST_F(VectorCanvasTest, DISABLED_Matrix) {
SkBitmap bitmap;
- LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap);
+ LoadPngFileToSkBitmap(test_file(L"..\\bitmaps\\bitmap_opaque.png"), &bitmap,
+ true);
{
vcanvas_->translate(15, 3);
pcanvas_->translate(15, 3);
« no previous file with comments | « DEPS ('k') | webkit/tools/layout_tests/test_expectations.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698