Add CheckChangeSvnEolStyle presubmit canned check.

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 import exceptions
 import random
 import string
@@ skipping 813 matching lines @@
     self.failIf(warning._Handle(output, input))
     self.failUnless(output.getvalue().count('???'))
 
 
 class AffectedFileUnittest(PresubmitTestsBase):
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
       'AbsoluteLocalPath', 'Action', 'IsDirectory', 'IsTextFile', 'LocalPath',
       'NewContents', 'OldContents', 'OldFileTempPath', 'Property', 'ServerPath',
+      'scm',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit.AffectedFile('a', 'b'), members)
     self.compareMembers(presubmit.SvnAffectedFile('a', 'b'), members)
 
   def testAffectedFile(self):
     path = presubmit.os.path.join('foo', 'blat.cc')
     presubmit.os.path.exists(path).AndReturn(True)
     presubmit.os.path.isdir(path).AndReturn(False)
     presubmit.gcl.ReadFile(path).AndReturn('whatever\ncookie')
@@ skipping 85 matching lines @@
     input_api.traceback = presubmit.traceback
     input_api.urllib2 = self.mox.CreateMock(presubmit.urllib2)
     input_api.unittest = unittest
     return input_api
 
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
       'CheckChangeHasBugField', 'CheckChangeHasNoCR', 'CheckChangeHasNoTabs',
       'CheckChangeHasQaField', 'CheckChangeHasTestedField',
-      'CheckChangeHasTestField', 'CheckDoNotSubmit',
+      'CheckChangeHasTestField', 'CheckChangeSvnEolStyle',
+      'CheckDoNotSubmit',
       'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
       'CheckLongLines', 'CheckTreeIsOpen', 'RunPythonUnitTests',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit_canned_checks, members)
 
   def TestDescription(self, check, description1, description2, error_type):
     input_api1 = self.MockInputApi()
     input_api1.change = self.MakeBasicChange('foo', 'Foo\n' + description1)
     input_api2 = self.MockInputApi()
@@ skipping 92 matching lines @@
   def testCannedCheckChangeHasNoTabs(self):
     self.TestContent(presubmit_canned_checks.CheckChangeHasNoTabs,
                      'blah blah', 'blah\tblah',
                      presubmit.OutputApi.PresubmitPromptWarning)
 
   def testCannedCheckLongLines(self):
     check = lambda x,y,z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
     self.TestContent(check, '', 'blah blah blah',
                      presubmit.OutputApi.PresubmitPromptWarning)
 
+
+  def testCheckChangeSvnEolStyle(self):
+    input_api1 = self.MockInputApi()
+    files1 = [
+      presubmit.SvnAffectedFile('foo/bar.cc', 'A'),
+      presubmit.SvnAffectedFile('foo.cc', 'M'),
+    ]
+    input_api1.AffectedSourceFiles(None).AndReturn(files1)
+    presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo/bar.cc'),
+                                     'svn:eol-style').AndReturn('LF')
+    presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo.cc'),
+                                     'svn:eol-style').AndReturn('LF')
+    input_api2 = self.MockInputApi()
+    files2 = [
+      presubmit.SvnAffectedFile('foo/bar.cc', 'A'),
+      presubmit.SvnAffectedFile('foo.cc', 'M'),
+    ]
+    input_api2.AffectedSourceFiles(None).AndReturn(files2)
+    presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo/bar.cc'),
+                                     'svn:eol-style').AndReturn('native')
+    presubmit.gcl.GetSVNFileProperty(presubmit.normpath('foo.cc'),
+                                     'svn:eol-style').AndReturn('CRLF')
+    self.mox.ReplayAll()
+
+    results1 = presubmit_canned_checks.CheckChangeSvnEolStyle(
+        input_api1, presubmit.OutputApi, None)
+    self.assertEquals(results1, [])
+    results2 = presubmit_canned_checks.CheckChangeSvnEolStyle(
+        input_api2, presubmit.OutputApi, None)
+    self.assertEquals(len(results2), 1)
+    self.assertEquals(results2[0].__class__, presubmit.OutputApi.PresubmitError)
+
   def testCannedCheckTreeIsOpenOpen(self):
     input_api = self.MockInputApi()
     input_api.is_committing = True
     connection = self.mox.CreateMockAnything()
     input_api.urllib2.urlopen('url_to_open').AndReturn(connection)
     connection.read().AndReturn('1')
     connection.close()
     self.mox.ReplayAll()
     results = presubmit_canned_checks.CheckTreeIsOpen(
         input_api, presubmit.OutputApi, url='url_to_open', closed='0')
@@ skipping 135 matching lines @@
     test_result.errors = 0
     self.mox.ReplayAll()
 
     results = presubmit_canned_checks.RunPythonUnitTests(
         input_api, presubmit.OutputApi, ['test_module'])
     self.assertEquals(len(results), 0)
 
 
 if __name__ == '__main__':
   unittest.main()