Issue 119420: Fix fp code for mixed-endian ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119420: Fix fp code for mixed-endian ARM. (Closed)

Created:
11 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
iposva, William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix fp code for mixed-endian ARM. Committed: http://code.google.com/p/v8/source/detail?r=2140

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -22 lines)			Patch
	M	src/arm/codegen-arm.cc	View		5 chunks	+26 lines, -20 lines	0 comments	Download
	M	src/objects.h	View		1 chunk	+9 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. How awful that there is that mixed-endian double representation.

11 years, 6 months ago (2009-06-10 13:52:30 UTC) #2

iposva

11 years, 6 months ago (2009-06-10 16:22:28 UTC) #3

LGTM. Especially the changes to name the contents in the registers instead of
using result1 and result2 make the bit twiddling code a lot more readable.

-Ivan

http://codereview.chromium.org/119420/diff/1/2
File src/objects.h (right):

http://codereview.chromium.org/119420/diff/1/2#newcode1175
Line 1175: # define BIG_ENDIAN_FLOATING_POINT
Please define BIG_ENDIAN_FLOATING_POINT to carry a value even if the value is
not used currently. For example as "#define USE_BLX 1". Thanks!

Expand Messages | Collapse Messages