Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 119414: Cleanup of ARM exception handlers. Remove the unused code and... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Cleanup of ARM exception handlers. Remove the unused code and parameter pointer slots. Change it so that the handler address no longer points into the middle of the handler. Committed: http://code.google.com/p/v8/source/detail?r=2129

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -352 lines) Patch
M src/arm/codegen-arm.cc View 8 chunks +58 lines, -55 lines 0 comments Download
M src/arm/frames-arm.h View 1 2 2 chunks +4 lines, -222 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +25 lines, -18 lines 0 comments Download
M src/arm/virtual-frame-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/frames.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/frames-inl.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/frames-x64.h View 1 chunk +4 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 2 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 6 months ago (2009-06-10 08:32:05 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/119414/diff/1/8 File src/arm/frames-arm.h (right): http://codereview.chromium.org/119414/diff/1/8#newcode330 Line 330: // C entry frames: When calling from ...
11 years, 6 months ago (2009-06-10 08:40:30 UTC) #2
Kevin Millikin (Chromium)
11 years, 6 months ago (2009-06-10 08:46:39 UTC) #3
Lasse, you may want to take a quick look at the x64 files.

Powered by Google App Engine
This is Rietveld 408576698