Issue 1194001: Add --jobs option to build_autotest.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1194001: Add --jobs option to build_autotest.sh (Closed)

Created:
10 years, 9 months ago by robotboy

Modified:
9 years, 7 months ago

Reviewers:
petkov, sosa

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Add --jobs option to build_autotest.sh

Patch Set 1 #

Total comments: 2

Patch Set 2 : add braces and double quotes. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/scripts/build_autotest.sh	View	1	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 9 months ago (2010-03-23 19:49:14 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/1194001/diff/1/2
File src/scripts/build_autotest.sh (right):

http://codereview.chromium.org/1194001/diff/1/2#newcode39
src/scripts/build_autotest.sh:39: if [[ $FLAGS_jobs -ne -1 ]]; then
use {} around script variables

http://codereview.chromium.org/1194001/diff/1/2#newcode40
src/scripts/build_autotest.sh:40: EMERGE_JOBS="--jobs=$FLAGS_jobs"
ditto

Expand Messages | Collapse Messages