Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 119393: Bind ^Q to quit, as is std with Linux GUI apps.... (Closed)

Created:
11 years, 6 months ago by Jacob Mandelson
Modified:
9 years, 7 months ago
Reviewers:
chromium-reviews, Evan Stade, tony
CC:
chromium-reviews_googlegroups.com, jlm_google.com, jacob_mandelson.org
Visibility:
Public.

Description

Bind ^Q to quit, as is std with Linux GUI apps. BUG=none TEST="base_unittests passes with 3 disabled tests, with one test flaky; app_unittests has one failing test, which also fails on unpatched build"

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/standard_menus.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jacob Mandelson
Add standard "Quit" keybinding.
11 years, 6 months ago (2009-06-09 23:08:10 UTC) #1
tony
Hi jlm, In the future, please try to pick a specific reviewer by using svn ...
11 years, 6 months ago (2009-06-09 23:58:42 UTC) #2
Evan Stade
On 2009/06/09 23:58:42, tony wrote: > Hi jlm, > > In the future, please try ...
11 years, 6 months ago (2009-06-10 00:59:48 UTC) #3
tony
11 years, 6 months ago (2009-06-10 21:14:50 UTC) #4
Landed in r18085.  Thanks for the patch!

Powered by Google App Engine
This is Rietveld 408576698