Issue 119363: Add a stack-based class for property disabling and re-enabling screen updatin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119363: Add a stack-based class for property disabling and re-enabling screen updatin... (Closed)

Created:
11 years, 6 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a stack-based class for property disabling and re-enabling screen updating without epic fail. Fixes issues where we weren't re-enabling updates in many cases which caused both jank and resize issues. BUG=13476 TEST=closing windows shouldn't have jank regardless of the # of tabs. Resizing a window shouldn't explode visually in the chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17956

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -4 lines)			Patch
M	base/base.gyp	View		1 chunk	+1 line, -0 lines	1 comment	Download
A	base/scoped_nsdisable_screen_updates.h	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	1	5 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 6 months ago (2009-06-09 16:39:59 UTC) #2

LGTM

http://codereview.chromium.org/119363/diff/1002/9
File base/base.gyp (right):

http://codereview.chromium.org/119363/diff/1002/9#newcode250
Line 250: 'scoped_nsdisable_screen_updates.h',
Do you understand the magic that keeps this out of the win/linux builds?

Expand Messages | Collapse Messages