Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 119361: Add a benchmark extension. (Closed)

Created:
11 years, 6 months ago by Mike Belshe
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a benchmark extension. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17948

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (0 generated)
Mike Belshe
11 years, 6 months ago (2009-06-09 15:56:03 UTC) #1
Mike Belshe
BTW - the jst/ files are JSTemplate from http://code.google.com/p/google-jstemplate/
11 years, 6 months ago (2009-06-09 15:59:12 UTC) #2
Erik does not do reviews
11 years, 6 months ago (2009-06-09 16:21:59 UTC) #3
LGTM

I'd add the jstemplate URL reference to the README as well.

http://codereview.chromium.org/119361/diff/1/7
File chrome/test/data/extensions/samples/benchmark/toolstrip.html (right):

http://codereview.chromium.org/119361/diff/1/7#newcode169
Line 169: <img src="stopwatch.jpg" height="25" width="25" align=top
onclick="show_options()">
style-wise, I'd wrap this in a toolstrip-button.  That way it's more clear that
it's a button.

Powered by Google App Engine
This is Rietveld 408576698